Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extra per-game data for matches #1

Open
Miss-Inputs opened this issue Nov 12, 2023 · 0 comments
Open

Extra per-game data for matches #1

Miss-Inputs opened this issue Nov 12, 2023 · 0 comments
Labels
enhancement New feature or request idea Just an idea that could be good or bad

Comments

@Miss-Inputs
Copy link
Owner

Miss-Inputs commented Nov 12, 2023

This will probably (should) be in a separate repo, but we want the ability to load it. If we have some match_data.jsonc containing stuff like:

{
	"match_id": 516311,
	"games": [
		{"winner": 10704,
		"winner_name": "Josh",
		"winner_ingame_tag": ".-.",
		"loser": 4724,
		"loser_name": "Miss Inputs",
		"loser_ingame_tag": "Megan",
		"stage": "Hollow Bastion",
		"winner_character": {
			"id": 347,
			"costume": null //default
		},
		"loser_character": {
			"id": 313,
			"costume": "Maid Outfit",
			"alt": "Guest F",
			"custom_moveset": [1, 1, 3, 1]
		},
		{"winner": 10704,
		"winner_name": "Josh",
		"winner_ingame_tag": ".-.",
		"loser": 4724,
		"loser_name": "Miss Inputs",
		"loser_ingame_tag": "Megan",
		"stage": "Hollow Bastion",
		"winner_character": {
			"id": 347,
			"costume": null
		},
		"loser_character": {
			"id": 296,
			"costume": "Hibiscus",
		}
	]
}

We can then have a class that I'll need to find a name for that isn't Game because that's ambiguous, maybe MatchGame or something, and return that from a Match.games property.

Also CostumedCharacter (subclass of Character, has costume and alt properties, alt loads different data from character_info if present), and CustomizedCharacter (subclass of CostumedCharacter, has .neutral_special/.side_special/etc properties returning int, and also just .moveset_name which is all of them combined or "default", "1131" in the first game there)

Should be able to create per-game data from start.gg when there's character data inputted there (hmm, maybe we need a function on Match to get the start.gg set ID in the event), or watch videos, and then start writing down stuff for my own matches.

@Miss-Inputs Miss-Inputs added enhancement New feature or request idea Just an idea that could be good or bad labels Nov 12, 2023
Miss-Inputs pushed a commit that referenced this issue Nov 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request idea Just an idea that could be good or bad
Projects
None yet
Development

No branches or pull requests

1 participant