Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add TensorFlow to lambda-packages #44

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jbencook
Copy link

This adds a TensorFlow tarball and build script as mentioned in #31. I've got a simple smoke test running here. I plan to write a more useful TensorFlow example in Zappa as soon as I have a little time.

@Miserlou
Copy link
Owner

Excellent!

But, can I ask - did the manylinux version of Tensorflow not work out of the box? It seems there are manylinux wheels available on PyPI: https://pypi.python.org/pypi/tensorflow

So, it should just automatically use those. Is this package optimized further?

@jbencook
Copy link
Author

Yeah it could be user error, but I couldn't get the manylinux version to work.

@Miserlou
Copy link
Owner

Can you be more specific about how it didn't work?

@jbencook
Copy link
Author

Hm... I can try to repro later, but I'm pretty sure the import tensorflow as tf line threw an error.

@brunoalano
Copy link
Contributor

@Miserlou I checked that, and it's because tensorflow has runtime dependency, and throws that error. But I think that this PR it's to heavy for lambda-packages.

Maybe we should think something about #36

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants