Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: NetworkTransformReliable to allow partial support of runtime changing sendIntervalMultiplier #3882

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

JesusLuvsYooh
Copy link
Contributor

@JesusLuvsYooh JesusLuvsYooh commented Aug 8, 2024

As discussed here:
https://discord.com/channels/343440455738064897/1270795122279186484/1271231586519486485

Opens up NTR for possible features such as network LOD/IM.
NTU already supports this.
Desynchronisation of position can happen if both sides have miss-matched values, but this PR at least is a step towards the right direction of the feature.

@JesusLuvsYooh JesusLuvsYooh changed the title feat: NetworkTransformReliable to allow runtime changing of sendIntervalMultiplier feat: NetworkTransformReliable to allow partial support of runtime changing sendIntervalMultiplier Aug 8, 2024
@miwarnec
Copy link
Collaborator

miwarnec commented Aug 9, 2024

Desynchronisation of position can happen if both sides have miss-matched values, but this PR at least is a step towards the right direction of the feature.

We can't merge this if it accidentally breaks people's projects

@JesusLuvsYooh
Copy link
Contributor Author

JesusLuvsYooh commented Aug 9, 2024

Desynchronisation of position can happen if both sides have miss-matched values, but this PR at least is a step towards the right direction of the feature.

We can't merge this if it accidentally breaks people's projects

It does not break projects, it won't do anything to previous or current users that do not intentionally try to change sendIntervalMultiplier during runtime.
Currently in master, if someone does change sendIntervalMultiplier during runtime, the entire movement just stops, and never works again.
(the counter variable has gone too high, and needs to be == to reset, we're just checking if counter is equal or higher to cover this >= )
With this PR, movement works again if changed during runtime, how well it works is spotty due to the nature of delta feature.

@realQuartzi
Copy link

It does not break projects, it won't do anything to previous or current users that do not intentionally try to change sendIntervalMultiplier during runtime.

I agree to this too.
This change should logically prevent any accidental runtime changes to sendIntervalMultiplier from causing issues, without affecting existing projects. I haven't tested it myself, but it looks like it should only impact situations where someone intentionally modifies sendIntervalMultiplier during runtime.

How well it works might still be a bit hit or miss due to the delta feature idk :3
I mean the tests say its okay >.<

@MrGadget1024 MrGadget1024 added enhancement New feature or request Awaiting Review labels Sep 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Review enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants