-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
make setup-aws-creds
fails with missing kubectl
#26
Comments
I only changed two lines of code in this PR to use a dockerized kubectl. No need to check versions, download, check signatures, etc. So far only tested with a couple of (random) Makefile targets, also has room for improvements, for instance
I'd like to hear opinions first before going down that road. @Schnitzel @Algeran |
I would prefer not to use containerized kubectl due to we use it a lot and start container each time to execute the kubectl command will increase the execution time of all demos significantly (take into account that not everyone run it on Mac M2 laptops). Additionally, for kubectl we use:
It's fine to use containers for some commands instead of downloading binaries if we use them 1-2 times during the whole demo (like openssl). For the particular issue we just forgot to replace |
I fixed and closed this issue to unblock demos. To continue usage of containerized binaries discussion, please create the separate issue |
make setup-aws-creds
does not use the on the fly installed kubectl, so if you don't have kubectl it fails:The text was updated successfully, but these errors were encountered: