Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support failing tests in validate* methods when certain errors appear for longer than a desired threshold #474

Open
squizzi opened this issue Oct 10, 2024 · 0 comments
Labels
test e2e Runs the entire provider E2E test suite, controller E2E tests are always ran

Comments

@squizzi
Copy link
Contributor

squizzi commented Oct 10, 2024

Currently we have a few validations like this one:

	if cluster != nil {
		phase, _, _ := unstructured.NestedString(cluster.Object, "status", "phase")
		if phase != "Deleting" {
			return fmt.Errorf("cluster: %q exists, but is not in 'Deleting' phase", clusterName)
		}

Where we are trying to validate a deletion and are waiting on a certain phase. In instances like this it doesn't make sense to spend 90m waiting for the cluster to enter 'Deleting' phase, instead we should probably only wait 60s here. It'd be nice to support a threshold where we call Fail after hitting a state that should exist for some time but not for a long time.

@squizzi squizzi added the test e2e Runs the entire provider E2E test suite, controller E2E tests are always ran label Oct 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test e2e Runs the entire provider E2E test suite, controller E2E tests are always ran
Projects
Status: Todo
Development

No branches or pull requests

1 participant