Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hook breaks with Thermos loadedTileEntityList cleanup #33

Closed
LunNova opened this issue Feb 6, 2016 · 4 comments
Closed

Hook breaks with Thermos loadedTileEntityList cleanup #33

LunNova opened this issue Feb 6, 2016 · 4 comments

Comments

@LunNova
Copy link
Member

LunNova commented Feb 6, 2016

CyberdyneCC/Thermos/issues/52

Not sure exactly what the problem is.

@LunNova LunNova added the bug label Feb 6, 2016
@LunNova LunNova self-assigned this Feb 6, 2016
@LunNova
Copy link
Member Author

LunNova commented Feb 6, 2016

Reports of KCauldron + TickProfiler causing entities to stop ticking.

I don't know which builds of either mod are being used. I have not received any reports here of the issue :/

@LunNova LunNova changed the title Possible bug with KCauldron + tick-rate limiting? Hook breaks with Thermos loadedTileEntityList cleanup Feb 6, 2016
@LunNova
Copy link
Member Author

LunNova commented Feb 6, 2016

Triggering this issue would result in this error:

Log.error("Looks like another mod broke TickProfiler's replacement entity list in world: " + Log.name(world));

@LunNova
Copy link
Member Author

LunNova commented Feb 6, 2016

Issue only occurs with Thermos, not KCauldron.

I will resolve this by dropping the hooking via entity lists and using a less fragile implementation with ModPatcher.

@LunNova
Copy link
Member Author

LunNova commented Feb 6, 2016

Fixed in 616fb94

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant