From 66420d4d0f7219ceb83bb9d287a4913de2e769c7 Mon Sep 17 00:00:00 2001 From: Mina Samir <48614170+MinaSamir11@users.noreply.github.com> Date: Wed, 13 Oct 2021 03:54:05 +0200 Subject: [PATCH] remove buildToolsVersion from build.gradle (#79) build tools version causing Gradle failure --- android/build.gradle | 1 - package.json | 178 +++++++++++++++++++++---------------------- 2 files changed, 89 insertions(+), 90 deletions(-) diff --git a/android/build.gradle b/android/build.gradle index 4dcb5b9..4e301f7 100755 --- a/android/build.gradle +++ b/android/build.gradle @@ -29,7 +29,6 @@ def safeExtGet(name) { android { compileSdkVersion safeExtGet('compileSdkVersion') - buildToolsVersion safeExtGet('buildToolsVersion') defaultConfig { minSdkVersion safeExtGet('minSdkVersion') diff --git a/package.json b/package.json index f2b44e5..03d8924 100755 --- a/package.json +++ b/package.json @@ -1,92 +1,92 @@ { - "name": "react-native-in-app-review", - "version": "3.2.2", - "description": "react native in app review, to rate on Play store, App Store, Generally, the in-app review flow (see figure 1 for play store, figure 2 for ios) can be triggered at any time throughout the user journey of your app. During the flow, the user has the ability to rate your app using the 1 to 5 star system and to add an optional comment for play store only. Once submitted, the review is sent to the Play Store or App store and eventually displayed.", - "main": "index.js", - "scripts": { - "test:package": "jest --ci --coverage __tests__/InAppReview-test.js InAppReviewWithoutNativeModules-test.js", - "test:example": "cd Example && jest --ci --coverage", - "test": "npm run test:package && npm run test:example", - "test:ci": "jest --ci --coverage", - "lint": "eslint . --fix" - }, - "keywords": [ - "react-native", - "review", - "app-review", - "in-app-review", - "react-native-in-app-review", - "store-kit", - "android", - "ios", - "app store", - "play store", - "rate your app", - "review is sent to the Play Store", - "review is sent to the App Store", - "rating", - "view", - "react-component", - "react-native-component" + "name": "react-native-in-app-review", + "version": "3.2.3", + "description": "react native in app review, to rate on Play store, App Store, Generally, the in-app review flow (see figure 1 for play store, figure 2 for ios) can be triggered at any time throughout the user journey of your app. During the flow, the user has the ability to rate your app using the 1 to 5 star system and to add an optional comment for play store only. Once submitted, the review is sent to the Play Store or App store and eventually displayed.", + "main": "index.js", + "scripts": { + "test:package": "jest --ci --coverage __tests__/InAppReview-test.js InAppReviewWithoutNativeModules-test.js", + "test:example": "cd Example && jest --ci --coverage", + "test": "npm run test:package && npm run test:example", + "test:ci": "jest --ci --coverage", + "lint": "eslint . --fix" + }, + "keywords": [ + "react-native", + "review", + "app-review", + "in-app-review", + "react-native-in-app-review", + "store-kit", + "android", + "ios", + "app store", + "play store", + "rate your app", + "review is sent to the Play Store", + "review is sent to the App Store", + "rating", + "view", + "react-component", + "react-native-component" + ], + "files": [ + "android/src/main/AndroidManifest.xml", + "android/src/main/java/", + "android/build.gradle", + "android/", + "ios/", + "!ios/build/", + "react-native-in-app-review.podspec", + "README.md", + "index.d.ts", + "index.js", + "__tests__" + ], + "repository": { + "type": "git", + "url": "git+https://github.com/MinaSamir11/react-native-in-app-review.git" + }, + "author": "Mina Samir Shafik ", + "license": "MIT", + "bugs": { + "url": "https://github.com/MinaSamir11/react-native-in-app-review/issues" + }, + "homepage": "https://github.com/MinaSamir11/react-native-in-app-review#readme", + "devDependencies": { + "@babel/core": "^7.8.4", + "@babel/runtime": "^7.8.4", + "@react-native-community/eslint-config": "^1.1.0", + "@testing-library/react-hooks": "^5.0.0", + "babel-jest": "^25.1.0", + "coveralls": "^3.1.0", + "eslint": "^6.5.1", + "eslint-plugin-unused-imports": "^1.0.1", + "husky": "^4.3.8", + "jest": "^25.1.0", + "lint-staged": "^10.5.3", + "metro-react-native-babel-preset": "^0.59.0", + "react": "16.13.1", + "react-native": "0.63.4", + "react-test-renderer": "16.13.1" + }, + "jest": { + "preset": "react-native", + "modulePathIgnorePatterns": [ + "/Example/" ], - "files": [ - "android/src/main/AndroidManifest.xml", - "android/src/main/java/", - "android/build.gradle", - "android/", - "ios/", - "!ios/build/", - "react-native-in-app-review.podspec", - "README.md", - "index.d.ts", - "index.js", - "__tests__" - ], - "repository": { - "type": "git", - "url": "git+https://github.com/MinaSamir11/react-native-in-app-review.git" - }, - "author": "Mina Samir Shafik ", - "license": "MIT", - "bugs": { - "url": "https://github.com/MinaSamir11/react-native-in-app-review/issues" - }, - "homepage": "https://github.com/MinaSamir11/react-native-in-app-review#readme", - "devDependencies": { - "@babel/core": "^7.8.4", - "@babel/runtime": "^7.8.4", - "@react-native-community/eslint-config": "^1.1.0", - "@testing-library/react-hooks": "^5.0.0", - "babel-jest": "^25.1.0", - "coveralls": "^3.1.0", - "eslint": "^6.5.1", - "eslint-plugin-unused-imports": "^1.0.1", - "husky": "^4.3.8", - "jest": "^25.1.0", - "lint-staged": "^10.5.3", - "metro-react-native-babel-preset": "^0.59.0", - "react": "16.13.1", - "react-native": "0.63.4", - "react-test-renderer": "16.13.1" - }, - "jest": { - "preset": "react-native", - "modulePathIgnorePatterns": [ - "/Example/" - ], - "setupFilesAfterEnv": [ - "/jest.setup.js" - ] - }, - "lint-staged": { - "*.{js,jsx}": [ - "eslint --fix", - "prettier --write" - ] - }, - "husky": { - "hooks": { - "pre-commit": "lint-staged -v && npm run test:ci" - } + "setupFilesAfterEnv": [ + "/jest.setup.js" + ] + }, + "lint-staged": { + "*.{js,jsx}": [ + "eslint --fix", + "prettier --write" + ] + }, + "husky": { + "hooks": { + "pre-commit": "lint-staged -v && npm run test:ci" } -} \ No newline at end of file + } +}