[Bug] undoable input rule

[ap0nia]

Initial checklist

• I agree to follow the code of conduct
• I searched issues and discussions and couldn’t find anything (or linked relevant results below)

Affected packages and versions

@milkdown/[email protected] @milkdown/[email protected]

Link to runnable example

No response

Steps to reproduce

1. Create an input rule, and pass in an object { undoable: false } as the third argument.
2. Load the input rule as a plugin, initialize the editor as usual.
3. Type into the editor and activate the input rule.
4. When pressing "Backspace," undoInputRule should not trigger.

Expected behavior

If an inputrule is specified as undoable, then pressing backspace should not do undoInputRule.

Actual behavior

The code ignores the undoable option because the run function differs from the upstream prosemirror-inputrules function.

Milkdown implementation

prosemirror-inputrules implementation

The solution is simply to add the check. Inputrules are undoable by default, so this should only affect users that are explicitly disabling the feature.

if (rule.undoable) {
  tr.setMeta(plugin, { transform: tr, from, to, text })
}
view.dispatch(tr)

Runtime

Chrome

OS

Windows

Build and bundle tools

Vite