Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

smart preview management, remove preview as inputs #1944

Merged
merged 2 commits into from
Aug 22, 2023
Merged

smart preview management, remove preview as inputs #1944

merged 2 commits into from
Aug 22, 2023

Conversation

lllyasviel
Copy link
Collaborator

smart preview management, remove preview as inputs
I tested openpose editor.
Please test yourself to see if anything is missing

@lllyasviel lllyasviel merged commit 36b3cfb into main Aug 22, 2023
@lllyasviel lllyasviel deleted the dev branch August 22, 2023 08:37
@Ineman
Copy link

Ineman commented Aug 22, 2023

  1. upload original image to controlnet
  2. run postprocess to make canny preview
  3. close original image
  4. postprocess preview image only in controlnet
  5. image generate -> doesn't work as controlnet

@lllyasviel
Copy link
Collaborator Author

  1. upload original image to controlnet
  2. run postprocess to make canny preview
  3. close original image
  4. postprocess preview image only in controlnet
  5. image generate -> doesn't work as controlnet

nice catch. but this seems impossible to fix since gradio does not have callback when image is removed

@lllyasviel
Copy link
Collaborator Author

oh wait. it is possible in newer gradio

@lllyasviel
Copy link
Collaborator Author

unfortunately this cannot be solved as gradio has a bug that Image.clear is broken on the listener

@Ineman
Copy link

Ineman commented Aug 22, 2023

It worked by 'preview as input' in past.
If this feature doesn't necessarily have to be removed, I think it's more convenient to have it.... Because original image having large filesize make web browser slow. So i need to download postprocessed canny image and input it again.
Some people, including myself, might feel this slightly inconvenient.

@lllyasviel
Copy link
Collaborator Author

image size only influence browser speed when uploading images.

@huchenlei
Copy link
Collaborator

LGTM. Thanks for fixing it. Verified that openpose editor still functions as expected.

@Prince-Mars
Copy link

Return preview as inputs! Please!

@silveroxides
Copy link
Contributor

What bug prompted this change? Was there something not working previously?
Because there obviously are issues as a result of this commit.

@Prince-Mars
Copy link

I think the original picture has an impact on the result. In Canny mode for sure.
Return preview as inputs! Please!

@Prince-Mars
Copy link

  • upload original image to controlnet
  • run postprocess to make canny preview
  • close original image
  • postprocess preview image only in controlnet
  • image generate -> doesn't work as controlnet

Same error

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants