Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve error handling #46

Open
MindOfMatter opened this issue Dec 30, 2020 · 0 comments
Open

Improve error handling #46

MindOfMatter opened this issue Dec 30, 2020 · 0 comments

Comments

@MindOfMatter
Copy link

MindOfMatter commented Dec 30, 2020

Would it be possible to add this code in speak function in order to better deal with voice errors?
please

utterance.addEventListener('error', function (event) {
    console.error("Failed to speak with \"" + voice.name + "\" voice, caused by :", event.error);
    cancel()
});

optionally it would be a good idea to add callbacks in the arguments for onend and error listener :

const {  onEnd= () => {}, onError= () => {} } = props;
...
utterance.addEventListener('error', function (event) {
    console.error("Failed to speak with \"" + voice.name + '" voice, caused by :', event.error);
    cancel()
    onError(event)
});
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant