Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kb.php?mode=cat > should provide an "edit" button #11

Open
vendethiel opened this issue Nov 4, 2014 · 4 comments
Open

kb.php?mode=cat > should provide an "edit" button #11

vendethiel opened this issue Nov 4, 2014 · 4 comments
Labels

Comments

@vendethiel
Copy link
Collaborator

there's currently "delete" and "unapprove", I think "edit" makes sense

NOTE: this is super-minor thing, and since KB isn't really maintained...

@vendethiel vendethiel reopened this Aug 24, 2016
@vendethiel vendethiel changed the title [KB] kb.php?mode=cat > should provide an "edit" button kb.php?mode=cat > should provide an "edit" button Aug 29, 2016
@vendethiel vendethiel added the kb label Aug 29, 2016
@MWE001
Copy link
Contributor

MWE001 commented Aug 30, 2016

Actually, those two buttons kind of threw me off for a minute or two with some serious thoughts involved.

How can I decide to unapprove a article unless I click on it and read it? The same goes for delete. And if there was an edit button there, I wouldn't know if it needed edited unless I was on the article itself anyhow.

So in my humblest of opinions, the unapprove and delete buttons needs to be on the bottom of the article next to the already there edit button. This is not a new thought to me. I thought this way back in the day on Integramod as well. I was going to move mine long ago but never did as the KB was never a big part of my site anyhow. Now it actually is needed. I will be using it.

I can see overall why you would want the edit button there. if I can get one added I'll come back and post.

@vendethiel
Copy link
Collaborator Author

Mmmh... As I said it's really minor. It's more about consistency.

@MWE001
Copy link
Contributor

MWE001 commented Aug 30, 2016

yep, I can see that. I am hot on the trail now. Just got done with dinner and am working on that button.

@MWE001
Copy link
Contributor

MWE001 commented Aug 30, 2016

Ok So I can find all the code but this one is a bit over my head. I can't do it. Was worth a try. I know when to say enough is enough.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants