API Review: Window management permission #3209
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oldnewthing
approved these changes
Feb 11, 2023
david-risney
approved these changes
Feb 15, 2023
| /// Indicates permission to open and place windows on the screen. Permission is | ||
| /// requested when developers use the [Multi-Screen Window Placement API](https://www.w3.org/TR/window-placement/) | ||
| /// to get screen details. | ||
| COREWEBVIEW2_PERMISSION_KIND_WINDOW_MANAGEMENT, |
There was a problem hiding this comment.
Any reason to call this 'management' rather than 'placement'? The underlying feature is placement, and management implies more than that.
There was a problem hiding this comment.
The permission in the DOM APIs is called window-management . They renamed it from window-placement to window-management to cover more than just placement for the API (ref).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.