Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[A11y]The card can be closed by esc key when focusing on the frame but cannot be closed by esc key when focusing on the field in frame. #11501

Closed
wanghe2015 opened this issue Aug 22, 2024 · 5 comments
Assignees
Labels
bug needs-author-feedback Needs more info from the customer. status-no-recent-activity teams-developer-support Question related to extensibility (Bot, ME, Tab) would be marked under this label

Comments

@wanghe2015
Copy link

Steps to reproduce

Hi team,
We are doing A11y test for the frame card in Teams. We found when focusing on the frame, the card can be closed by esc key. But if it is not focusing on the frame, for example, it is focusing on the field in the frame, esc key cannot close the card.

Expected behavior

Is it working by design? - When focusing on the frame, esc key can close the card. But when focusing on the field in the frame, esc key cannot close the card.

Actual behavior

When focusing on the frame, esc key can close the card. But when focusing on the field in the frame, esc key cannot close the card.

image image

Error details

No response

Copy link
Contributor

Hi wanghe2015! Thank you for bringing this issue to our attention. We will investigate and if we require further information we will reach out in one business day. Please use this link to escalate if you don't get replies.

Best regards, Teams Platform

@Nivedipa-MSFT
Copy link

@wanghe2015 - Thanks for reporting your issue. We will test this and update you soon.

@Meghana-MSFT Meghana-MSFT self-assigned this Aug 22, 2024
@Meghana-MSFT Meghana-MSFT added teams-developer-support Question related to extensibility (Bot, ME, Tab) would be marked under this label and removed needs-triage 🔍 labels Aug 22, 2024
@Meghana-MSFT
Copy link
Collaborator

We are able to repro this using an ME based action app. We checked using Polls app.

Focus on the Frame: Esc key closes the popup:
image

Focus on elements inside frame: Esc key doesn't close the popup
image

We raised a bug for this, we will keep you posted on the updates. Thank you.

@Meghana-MSFT
Copy link
Collaborator

Engineering team has looked into this and said that there is nothing Teams can do about this issue when an iframe/webview-based dialog is used. App developers can implement this behavior on their end by handing the ESC key press and calling the dialog.url.submit API:
https://learn.microsoft.com/en-us/javascript/api/@microsoft/teams-js/dialog.url?view=msteams-client-js-latest#@microsoft-teams-js-dialog-url-submit

Copy link
Contributor

This issue has been automatically marked as stale because it has been marked as requiring author feedback but has not had any activity for 3 days. It will be closed if no further activity occurs within 3 days of this comment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug needs-author-feedback Needs more info from the customer. status-no-recent-activity teams-developer-support Question related to extensibility (Bot, ME, Tab) would be marked under this label
Projects
None yet
Development

No branches or pull requests

4 participants