Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added new forex provider to fix "Currency Rates Source Not Ready" #127

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Added new forex provider to fix "Currency Rates Source Not Ready" #127

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a8e7e76
Changed forex provider and added a check to fix unit test
Feb 9, 2023
73c330b
fixed spacing
Feb 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions forex_python/converter.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,21 +25,23 @@ def __init__(self, force_decimal=False):
self._force_decimal = force_decimal

def _source_url(self):
return "https://theforexapi.com/api/"
return "https://api.exchangerate.host/"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why not allow specying source url as parameter?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Most apis are not going to be this similar in terms of api surface. This one is 95% there so still requires minor changes. I don't think having the provider url as a parameter makes sense unless theforexapi.com comes back online again.

If supporting multiple apis is required there needs to be some refactoring to abstract the api provider from the currency class.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It makes sense, you can host your own api since theforexapi is open source, there should be an option to override the url...


def _get_date_string(self, date_obj):
if date_obj is None:
return 'latest'
date_str = date_obj.strftime('%Y-%m-%d')
return date_str

def _decode_rates(self, response, use_decimal=False, date_str=None):
def _decode_rates(self, response, use_decimal=False, date_str=None,base_cur=None):
Copy link

@matech96 matech96 Feb 11, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing sapce before ,

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

if self._force_decimal or use_decimal:
decoded_data = json.loads(response.text, use_decimal=True)
else:
decoded_data = response.json()
# if (date_str and date_str != 'latest' and date_str != decoded_data.get('date')):
# raise RatesNotAvailableError("Currency Rates Source Not Ready")
if base_cur != None and base_cur != decoded_data['base']:
raise RatesNotAvailableError("Currency Rates Source Not Ready")
return decoded_data.get('rates', {})

def _get_decoded_rate(
Expand All @@ -57,7 +59,7 @@ def get_rates(self, base_cur, date_obj=None):
source_url = self._source_url() + date_str
response = requests.get(source_url, params=payload)
if response.status_code == 200:
rates = self._decode_rates(response, date_str=date_str)
rates = self._decode_rates(response,date_str=date_str,base_cur=base_cur)
Copy link

@matech96 matech96 Feb 11, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing sapce before ,

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

return rates
raise RatesNotAvailableError("Currency Rates Source Not Ready")

Expand Down