Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

addResolversToSchema example no longer functional after Apollo update #1274

Closed
dobrynin opened this issue May 5, 2022 · 3 comments
Closed
Assignees
Labels
Community 👨‍👧 Something initiated by a community Documentation 📖 Issues about docs Solved ✔️ The issue has been solved

Comments

@dobrynin
Copy link
Contributor

dobrynin commented May 5, 2022

Describe the issue
The Apollo Federation example no longer works as written in this file: https://github.com/MichalLytek/type-graphql/blob/master/examples/apollo-federation/helpers/buildFederatedSchema.ts

Apollo has changed how __resolveReference works and has improved support for Directives in a federated graph. Issues discussed in #369 can likely be dealt with now.

See here for the discussion in the federation repo about this issue: apollographql/federation#1747

Are you able to make a PR that fix this?
I currently don't have enough understanding of type-graphql internals to propose a specific code change for this. At a minimum we can update the sample code to use the workaround discussed in the Federation repo (all this involves is changing where addResolversToSchema is imported from).

@MichalLytek
Copy link
Owner

This is part of examples, documentation not a core code. It's highly possible that it might be outdated and does not work with the latest version. I will do my best to update it along with the v16 branch.

@MichalLytek MichalLytek added Community 👨‍👧 Something initiated by a community Documentation 📖 Issues about docs labels May 6, 2022
@MichalLytek MichalLytek self-assigned this May 6, 2022
@dobrynin
Copy link
Contributor Author

dobrynin commented May 6, 2022

Thanks @MichalLytek! Appreciate your excellent work on this library.

@MichalLytek
Copy link
Owner

Closed by #1331 🔒

@MichalLytek MichalLytek added the Solved ✔️ The issue has been solved label Feb 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Community 👨‍👧 Something initiated by a community Documentation 📖 Issues about docs Solved ✔️ The issue has been solved
Projects
None yet
Development

No branches or pull requests

2 participants