Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Foreman Orchestration class to run the model hooks #16

Open
edestecd opened this issue Jan 18, 2018 · 3 comments
Open

Use Foreman Orchestration class to run the model hooks #16

edestecd opened this issue Jan 18, 2018 · 3 comments

Comments

@edestecd
Copy link
Member

This is a more structured way to do things and it ties into Foreman hooks for the progress bar upon host creation etc...

Here are orchestrations in core Foreman: https://github.com/theforeman/foreman/tree/006929d1057d5b59458d4fbf99cd20853c198ffd/app/models/concerns/orchestration

Here is a plugin that adds an orchestration: https://github.com/theforeman/puppetdb_foreman/blob/master/app/models/concerns/orchestration/puppetdb.rb#L13

@nipendar
Copy link
Contributor

would need @edestecd's help on this to figure out how puppetdb initializes the Orchestration class since it is not in engine.rb and my first stab at it didn't work.

estimate it 4 hours (may change)

@nipendar
Copy link
Contributor

nipendar commented Feb 7, 2018

@edestecd do we really want this since model extensions are working just fine.

@edestecd
Copy link
Member Author

edestecd commented Feb 7, 2018

Yes, this will improve user experience by adding it to the progress bar on new hosts

And also provide hooks for failure etc. This is the preferred path for adding items to the orchestration of a host.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants