From d0d7151ffde9cf5f83f0f43ac61fc060f486a2e2 Mon Sep 17 00:00:00 2001 From: Evgeny Gorodetskiy Date: Tue, 31 Dec 2024 11:26:49 +0300 Subject: [PATCH] Enable Metal Argument Buffers as a primary binding mechanism by default --- Build/README.md | 2 +- CMakeLists.txt | 2 +- CMakePresets.json | 8 ++++++++ 3 files changed, 10 insertions(+), 2 deletions(-) diff --git a/Build/README.md b/Build/README.md index b67a32ef1..d16f70b96 100644 --- a/Build/README.md +++ b/Build/README.md @@ -217,7 +217,7 @@ cmake -G [Generator] ... -D[BUILD_OPTION_NAME]:BOOL=[ON|OFF] | METHANE_APPLE_CODE_SIGNING_ENABLED | OFF | OFF | OFF | Enable code signing on Apple platforms (requires APPLE_DEVELOPMENT_TEAM) | | METHANE_METAL_FRAMES_SYNC_WITH_DISPATCH_SEMAPHORE | OFF | OFF | OFF | Enable Metal frame synchronization with dispatch semaphore instead of fence | | METHANE_METAL_SHADER_CONVERTER_ENABLED | OFF | OFF | OFF | Enable Metal Shader Converter instead of SPIRV-Cross (Experimental) | -| METHANE_METAL_ARGUMENT_BUFFERS_ENABLED | OFF | OFF | OFF | Enable Metal Argument Buffers for shader bindings with SPIRV-Cross (Experimental) | +| METHANE_METAL_ARGUMENT_BUFFERS_ENABLED | ON | ON | ON | Enable Metal Argument Buffers for shader bindings with SPIRV-Cross (Experimental) | ### CMake Presets diff --git a/CMakeLists.txt b/CMakeLists.txt index e2dda9045..a81b91979 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -71,7 +71,7 @@ option(METHANE_OPEN_IMAGE_IO_ENABLED "Enable using OpenImageIO library fo if(APPLE) option(METHANE_METAL_FRAMES_SYNC_WITH_DISPATCH_SEMAPHORE "Enable Metal frame synchronization with dispatch semaphore instead of fence" OFF) option(METHANE_METAL_SHADER_CONVERTER_ENABLED "Enable Apple Metal Shader Converter instead of SPIRV-Cross" OFF) - option(METHANE_METAL_ARGUMENT_BUFFERS_ENABLED "Enable Metal Argument Buffers for Program Resource Bindings" OFF) + option(METHANE_METAL_ARGUMENT_BUFFERS_ENABLED "Enable Metal Argument Buffers for Program Resource Bindings" ON) endif() # Profiling and instrumentation configuration diff --git a/CMakePresets.json b/CMakePresets.json index 13677b99a..c401cd3e7 100644 --- a/CMakePresets.json +++ b/CMakePresets.json @@ -99,6 +99,14 @@ "METHANE_APPLE_CODE_SIGNING_ENABLED": { "type": "BOOL", "value": "OFF" + }, + "METHANE_METAL_SHADER_CONVERTER_ENABLED": { + "type": "BOOL", + "value": "OFF" + }, + "METHANE_METAL_ARGUMENT_BUFFERS_ENABLED": { + "type": "BOOL", + "value": "ON" } } },