-
-
Notifications
You must be signed in to change notification settings - Fork 136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove autopublish for sub-documents #453
Comments
Thank you for submitting this issue! We, the Members of Meteor Community Packages take every issue seriously. However, we contribute to these packages mostly in our free time. If you think this issue is trivial to solve, don't hesitate to submit Please also consider sponsoring the maintainers of the package. |
Hey @raragaodl, that seems like a sensible update. Can you create a PR and I'll try review ? |
I can publish a new version or beta version, if needed |
Great guys, I will create a PR. |
@lynchem @jankapunkt , PR created. |
Is your feature request related to a problem? Please describe.
I'm using Tabular with a collection with many fields and a lot of them in subdocuments
Example:
So when I want to create a tabular with the field1 and field3, I just put definition of data as 'subDoc1.field1', and 'subDoc2.field3'. This works fine, no issues
The problem is that Tabular publish just use the top level field name to publish the document. Then, all fields are being published to the client.
Describe the solution you'd like
I took a look on the code and see in the file
tableInit.js
a line that remove the sub-fields name, returning just the main level of the fields. The line is 36 with the code:Describe alternatives you've considered
None
Additional context
I did a test to my scenario removing the cleanFieldName call, and all the functions seems as fine.
new code:
Just to understanding, with this change I could reduce data size on client in 80% in my case, and I don't expose any unnecessary data to client.
The text was updated successfully, but these errors were encountered: