Add uint256.ToSpanString()
#1198
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
kiminuo
commented
Jan 9, 2024
•
kiminuo
commented
| Method | destinationSpan | Mean | Error | StdDev |
|---|---|---|---|---|
| WriteToString | ? | 92.973 ns | 1.8389 ns | 3.7977 ns |
| WriteToSpanString | Char[64] | 59.165 ns | 1.0388 ns | 0.9209 ns |
kiminuo
commented
Jan 9, 2024
| @@ -41,8 +41,8 @@ | |||
| <ProjectReference Include="..\NBitcoin.Altcoins\NBitcoin.Altcoins.csproj" /> | |||
| <ProjectReference Include="..\NBitcoin.TestFramework\NBitcoin.TestFramework.csproj" /> | |||
| <PackageReference Include="Microsoft.CSharp" Version="4.6.0" /> | |||
| <PackageReference Include="xunit" Version="2.4.1" /> | |||
| <PackageReference Include="xunit.runner.visualstudio" Version="2.4.1"> | |||
| <PackageReference Include="xunit" Version="2.6.5" /> | |||
There was a problem hiding this comment.
To allow testing with spans.
kiminuo
commented
Jan 9, 2024
kiminuo
referenced
this pull request
in turbolay/WalletWasabi
Jan 9, 2024
kiminuo
force-pushed
the
feature/2024-01-09-Add-uint256-ToSpanString
branch
from
befb119
to
ba3987c
Compare
kiminuo
force-pushed
the
feature/2024-01-09-Add-uint256-ToSpanString
branch
from
ba3987c
to
532919d
Compare
kiminuo
force-pushed
the
feature/2024-01-09-Add-uint256-ToSpanString
branch
from
0374d0b
to
ff16374
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.