Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rename yeast map #35

Open
mihai-sysbio opened this issue Apr 8, 2023 · 4 comments
Open

rename yeast map #35

mihai-sysbio opened this issue Apr 8, 2023 · 4 comments
Labels
bug Something isn't working

Comments

@mihai-sysbio
Copy link
Member

mihai-sysbio commented Apr 8, 2023

One of the subsystem maps for yeast-GEM has an inaccurate title. As suggested by @IVANDOMENZAIN, it should just be "Carbon metabolism" (without "alternate"). The fix should a rename in this line:

https://github.com/MetabolicAtlas/data-files/blob/main/integrated-models/Yeast-GEM/subsystemSVG.tsv#L51

Feel free to ask a PR review from @IVANDOMENZAIN.

@mihai-sysbio mihai-sysbio added the bug Something isn't working label Apr 8, 2023
@perjo
Copy link

perjo commented Apr 14, 2023

Should the occurrences of the "Alternative carbon metabolism" in yeastGEM.yaml be changed as well? @mihai-sysbio

@mihai-sysbio
Copy link
Member Author

Should the occurrences of the "Alternative carbon metabolism" in yeastGEM.yaml be changed as well? @mihai-sysbio

Great job thinking about this @perjo, I've asked on SysBioChalmers/yeast-GEM#335

@perjo perjo self-assigned this Apr 14, 2023
@IVANDOMENZAIN
Copy link

IVANDOMENZAIN commented Apr 16, 2023

The alternate carbon metabolism subsystem is not a KEGG subsystem, it is not clear to me what's the origin of such category in yeastGEM (I have also commented in the yeastGEM repo discussion). The reactions annotated with this subsystem are just a few (around 16) and they seem to not be interconnected in a "pathway" manner, therefore, representation in a map would be difficult, as they may connect to central carbon metabolism in very different/distant points.

@perjo
Copy link

perjo commented Apr 18, 2023

On hold for discussion on how to solve this.

@perjo perjo removed their assignment Apr 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants