Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Update Snap] ShapeShift Multichain #160

Open
4 tasks
Montoya opened this issue Sep 12, 2023 · 2 comments
Open
4 tasks

[Update Snap] ShapeShift Multichain #160

Montoya opened this issue Sep 12, 2023 · 2 comments

Comments

@Montoya
Copy link
Contributor

Montoya commented Sep 12, 2023

Checklist

All items in the list below needs to be satisfied.

  • Is the summary of the change documented in this ticket?
  • Has a MetaMask Snaps team member reviewed whether the changes need to be vetted?
  • If there are changes that need to be vetted, attach a description and the relevant fixes/remediations to this issue.
  • The corresponding pull request in this repo has been merged.
@Montoya
Copy link
Contributor Author

Montoya commented Sep 12, 2023

This change involves preventing the user from signing when they are connecting an Ethereum account that is not derived from the SRP. This fixes an issue where the user can encounter unexpected behavior when connecting Snap multichain accounts derived from the SRP while also connected an Ethereum account that is not derived from the SRP.

@Montoya
Copy link
Contributor Author

Montoya commented Sep 12, 2023

This update is on hold. For now, the ShapeShift website has been updated to make sure users only connect with their SRP derived ETH account.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant