Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: Uncontrolled error when executing a TX #12696

Open
racitores opened this issue Dec 13, 2024 · 9 comments · May be fixed by #13138
Open

[Bug]: Uncontrolled error when executing a TX #12696

racitores opened this issue Dec 13, 2024 · 9 comments · May be fixed by #13138
Assignees
@vinistevam
Labels
release-blocker This bug is blocking the next release Sev1-high An issue that may have caused fund loss or access to wallet in the past & may still be ongoing team-confirmations Push issues to confirmations team type-bug Something isn't working

Comments

@racitores
Copy link

Describe the bug

Android (crash) and iOS (uncontrolled error) app failed as a result of a custom transaction with low gas. Using STX on uniswap.

Note: the first time it happened, the application crashed (android) and when we tried to open it again, it requested to reset, going again to the SRP process and loosing all previous logs / info. We weren't able to reproduce it again

Expected behavior

The tx should fail, and be listed as fail in the Activity tab

Screenshots/Recordings

Screen.Recording.2024-12-13.at.11.07.25.mov

Image
Image
Image

Steps to reproduce

  1. Go to uniswap
  2. swap eth for weth (mainnet)
  3. accept on uniswap
  4. on MM select custom config -> gas
  5. add very low values (the closest to 0 allowed by the app)
  6. Accept the tx
  7. the error should appear

Check the video for more detail and error output

Error messages or log output

Included in the screenshots/recording area of this issue

Detection stage

During release testing

Version

7.38.0

Build type

None

Device

Android

Operating system

Other (please elaborate in the "Additional Context" section)

Additional context

It happen on both Android and iOS

Severity

sev2
@racitores racitores added the type-bug Something isn't working label Dec 13, 2024
@github-project-automation github-project-automation bot moved this to To be fixed in Bugs by team Dec 13, 2024
@github-project-automation github-project-automation bot moved this to To be fixed in Bugs by severity Dec 13, 2024
@metamaskbot metamaskbot added the regression-RC-7.38.0 Regression bug that was found in release candidate (RC) for release 7.38.0 label Dec 13, 2024
@racitores racitores added the Sev2-normal An issue that may lead to users misunderstanding some limited risks they are taking label Dec 13, 2024
@smilingkylan smilingkylan added the team-transactions Transactions team label Jan 6, 2025
@forest-diggs-consensys forest-diggs-consensys added team-confirmations Push issues to confirmations team and removed team-transactions Transactions team labels Jan 13, 2025
@forest-diggs-consensys
Copy link
Contributor

Reassigning to confirmations team - users should not be able to click/tap save when inputting invalid params for gas

@sleepytanya
Copy link
Contributor

Might it be related to Intrinsic gas too low bug, that was fixed yesterday by @OGPoyraz?

Swap either fails on iOS with low gas fees:

ios_fail.mov
Image

or iOS crashes:

ios_crash.mov

Android seems to always quit with low swap gas fees:

android_crash.mp4

Error message:

Image

@sleepytanya
Copy link
Contributor

Tried on branch with fix for Intrinsic gas too low bug - the issue occurs in this build too , with the same error message:

branch_crash.mov

@pnarayanaswamy pnarayanaswamy added Sev1-high An issue that may have caused fund loss or access to wallet in the past & may still be ongoing and removed Sev2-normal An issue that may lead to users misunderstanding some limited risks they are taking labels Jan 20, 2025
@sleepytanya
Copy link
Contributor

Bug is present on other Popular networks too.

@vpintorico vpintorico added the release-blocker This bug is blocking the next release label Jan 21, 2025
@sleepytanya
Copy link
Contributor

This issue is present in 7.37.1:

7_37_1.mp4

@bschorchit bschorchit removed the regression-RC-7.38.0 Regression bug that was found in release candidate (RC) for release 7.38.0 label Jan 21, 2025
@Unik0rnMaggie
Copy link
Contributor

Not present on v7.39.0 (1529)

Arbitrum.swap.Uniswap.mov
Base.swap.Uniswap.mov

@vpintorico
Copy link
Contributor

Hi @Unik0rnMaggie, since this issue is not present in 7.39.0. Can we close it?

@Unik0rnMaggie
Copy link
Contributor

Hi @vpintorico I believe so!

With the latest RC7.39.0 (1535) on Ethereum Mainnet, when setting custom gas too low, the Tx is cancelled, there is no error:

Hi @racitores Can we close this issue if the error is not present in v7.39.0?

Swap.uniswap.ethereum1.mov
Swap.Uniswap.ethereum.Mainnet.mov

@vinistevam vinistevam linked a pull request Jan 23, 2025 that will close this issue
Open
7 tasks
@vinistevam
Copy link
Contributor

Hey @Unik0rnMaggie, could you try setting the gas limit to 21000? 🙏
I believe this is an old issue since 7.35-34 , hopefully, It is fixed but it is worth to double check with those values. It will trigger the RPC error and cause the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vinistevam vinistevam

Labels
release-blocker This bug is blocking the next release Sev1-high An issue that may have caused fund loss or access to wallet in the past & may still be ongoing team-confirmations Push issues to confirmations team type-bug Something isn't working
Projects
Bugs by severity
Status: To be fixed
Bugs by team
Status: To be fixed
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: mobile crash issue during swap with low gas MetaMask/metamask-mobile
10 participants
@vpintorico @smilingkylan @pnarayanaswamy @bschorchit @racitores @metamaskbot @vinistevam @sleepytanya @forest-diggs-consensys @Unik0rnMaggie