[Bug]: Token list does not update when switching networks using the RPC Link #13091
Assignees
Labels
regression-RC-7.39.0
Regression bug that was found in release candidate (RC) for release 7.39.0
release-7.40.0
Issue or pull request that will be included in release 7.40.0
release-blocker
This bug is blocking the next release
Sev2-normal
An issue that may lead to users misunderstanding some limited risks they are taking
team-assets
type-bug
Something isn't working
Comments
metamaskbot
added
the
regression-RC-7.39.0
Unik0rnMaggie
added
release-blocker
gauthierpetetin
added
the
Sev2-normal
7 tasks
github-merge-queue bot
pushed a commit
that referenced
this issue
Jan 22, 2025
## **Description** When the user adds multiple RPCs for a certain network and switch between networks by clicking on the RPC link; the tokenList does not update correctly ## **Related issues** Fixes: #13091 ## **Manual testing steps** 1. Click on Network filter 2. Add new RPC for a network 3. Switch back and forth between networks by clicking on the rpc link 4. You should see correct tokenList ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** <!-- [screenshots/recordings] --> Checkout video in the linked issue 🙏 ### **After** <!-- [screenshots/recordings] --> https://github.com/user-attachments/assets/aff21d16-db9d-4c1e-9150-bf9176f89846 ## **Pre-merge author checklist** - [ ] I’ve followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've completed the PR template to the best of my ability - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
metamaskbot
added
the
release-7.40.0
runway-github bot
added a commit
that referenced
this issue
Jan 22, 2025
## **Description** When the user adds multiple RPCs for a certain network and switch between networks by clicking on the RPC link; the tokenList does not update correctly ## **Related issues** Fixes: #13091 ## **Manual testing steps** 1. Click on Network filter 2. Add new RPC for a network 3. Switch back and forth between networks by clicking on the rpc link 4. You should see correct tokenList ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** <!-- [screenshots/recordings] --> Checkout video in the linked issue 🙏 ### **After** <!-- [screenshots/recordings] --> https://github.com/user-attachments/assets/aff21d16-db9d-4c1e-9150-bf9176f89846 ## **Pre-merge author checklist** - [ ] I’ve followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've completed the PR template to the best of my ability - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
runway-github bot
added a commit
that referenced
this issue
Jan 22, 2025
## **Description** When the user adds multiple RPCs for a certain network and switch between networks by clicking on the RPC link; the tokenList does not update correctly ## **Related issues** Fixes: #13091 ## **Manual testing steps** 1. Click on Network filter 2. Add new RPC for a network 3. Switch back and forth between networks by clicking on the rpc link 4. You should see correct tokenList ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** <!-- [screenshots/recordings] --> Checkout video in the linked issue 🙏 ### **After** <!-- [screenshots/recordings] --> https://github.com/user-attachments/assets/aff21d16-db9d-4c1e-9150-bf9176f89846 ## **Pre-merge author checklist** - [ ] I’ve followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've completed the PR template to the best of my ability - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
runway-github bot
pushed a commit
that referenced
this issue
Jan 22, 2025
…on (#13097) ## **Description** When the user adds multiple RPCs for a certain network and switch between networks by clicking on the RPC link; the tokenList does not update correctly ## **Related issues** Fixes: #13091 ## **Manual testing steps** 1. Click on Network filter 2. Add new RPC for a network 3. Switch back and forth between networks by clicking on the rpc link 4. You should see correct tokenList ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** <!-- [screenshots/recordings] --> Checkout video in the linked issue 🙏 ### **After** <!-- [screenshots/recordings] --> https://github.com/user-attachments/assets/aff21d16-db9d-4c1e-9150-bf9176f89846 ## **Pre-merge author checklist** - [ ] I’ve followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've completed the PR template to the best of my ability - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
7 tasks
sahar-fehri
added a commit
that referenced
this issue
Jan 22, 2025
## **Description** When the user adds multiple RPCs for a certain network and switch between networks by clicking on the RPC link; the tokenList does not update correctly ## **Related issues** Fixes: #13091 ## **Manual testing steps** 1. Click on Network filter 2. Add new RPC for a network 3. Switch back and forth between networks by clicking on the rpc link 4. You should see correct tokenList ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** <!-- [screenshots/recordings] --> Checkout video in the linked issue 🙏 ### **After** <!-- [screenshots/recordings] --> https://github.com/user-attachments/assets/aff21d16-db9d-4c1e-9150-bf9176f89846 ## **Pre-merge author checklist** - [ ] I’ve followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've completed the PR template to the best of my ability - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
14 tasks
sethkfman
pushed a commit
that referenced
this issue
Jan 23, 2025
## **Description** Cherry picks #13097 ## **Related issues** Fixes: #13091 ## **Manual testing steps** 1. Click on Network filter 2. Add new RPC for a network 3. Switch back and forth between networks by clicking on the rpc link 4. You should see correct tokenList ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** <!-- [screenshots/recordings] --> Checkout video in the linked issue 🙏 ### **After** <!-- [screenshots/recordings] --> https://github.com/user-attachments/assets/aff21d16-db9d-4c1e-9150-bf9176f89846 ## **Pre-merge author checklist** - [ ] I’ve followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've completed the PR template to the best of my ability - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. <!-- Please submit this PR as a draft initially. Do not mark it as "Ready for review" until the template has been completely filled out, and PR status checks have passed at least once. --> ## **Description** <!-- Write a short description of the changes included in this pull request, also include relevant motivation and context. Have in mind the following questions: 1. What is the reason for the change? 2. What is the improvement/solution? --> ## **Related issues** Fixes: ## **Manual testing steps** 1. Go to this page... 2. 3. ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** <!-- [screenshots/recordings] --> ### **After** <!-- [screenshots/recordings] --> ## **Pre-merge author checklist** - [ ] I’ve followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've completed the PR template to the best of my ability - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
When switching networks using the RPC Link, the token list does not update, showing the tokens from the previously selected network
Expected behavior
Token list to update
Screenshots/Recordings
Switch.Network.RPC.link.iOS.mov
Switch.Network.RPC.link.Android.mov
Steps to reproduce
Error messages or log output
Detection stage
During release testing
Version
7.39.0
Build type
None
Device
iPhone 15, Pixel 6 Pro
Operating system
iOS, Android
Additional context
No response
Severity
No response
The text was updated successfully, but these errors were encountered: