Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] Upgrade hw-app-eth library to v6.42.0 for Ledger Clear Signing #13086

Open
vivek-consensys opened this issue Jan 21, 2025 · 1 comment · May be fixed by #13088
Open

[Bug] Upgrade hw-app-eth library to v6.42.0 for Ledger Clear Signing #13086

vivek-consensys opened this issue Jan 21, 2025 · 1 comment · May be fixed by #13088
Assignees
@dawnseeker8
Labels
INVALID-ISSUE-TEMPLATE Issue's body doesn't match any issue template. regression-prod-7.38.0 Regression bug that was found in production in release 7.38.0 Sev2-normal An issue that may lead to users misunderstanding some limited risks they are taking team-hardware-wallets type-bug Something isn't working

Comments

@vivek-consensys
Copy link
Contributor

vivek-consensys commented Jan 21, 2025 •
edited
Loading

  • Without 6.42.0, when EIP-712 content is not sorted as defined in solidity struct “types” , the user can be blocked.
  • Without 6.41.0, for some legacy transaction (type 0), the v signature can be wrong and the transaction won’t be broadcasted

Thread: https://consensys.slack.com/archives/C02CYKAA8G1/p1737381638976519?thread_ts=1737106010.543919&cid=C02CYKAA8G1
@vivek-consensys vivek-consensys added regression-prod-7.38.0 Regression bug that was found in production in release 7.38.0 team-hardware-wallets type-bug Something isn't working labels Jan 21, 2025
@github-project-automation github-project-automation bot moved this to To be fixed in Bugs by severity Jan 21, 2025
@github-project-automation github-project-automation bot moved this to To be fixed in Bugs by team Jan 21, 2025
@metamaskbot metamaskbot added the INVALID-ISSUE-TEMPLATE Issue's body doesn't match any issue template. label Jan 21, 2025
@vivek-consensys vivek-consensys added the Sev1-high An issue that may have caused fund loss or access to wallet in the past & may still be ongoing label Jan 21, 2025
@dawnseeker8
Copy link
Contributor

PR has been created in account repo . MetaMask/accounts#153

will upgrade in extension repo after above PR release.

@dawnseeker8 dawnseeker8 linked a pull request Jan 21, 2025 that will close this issue
Open
7 tasks
@angelcheung22 angelcheung22 added Sev2-normal An issue that may lead to users misunderstanding some limited risks they are taking and removed Sev1-high An issue that may have caused fund loss or access to wallet in the past & may still be ongoing labels Jan 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dawnseeker8 dawnseeker8

Labels
INVALID-ISSUE-TEMPLATE Issue's body doesn't match any issue template. regression-prod-7.38.0 Regression bug that was found in production in release 7.38.0 Sev2-normal An issue that may lead to users misunderstanding some limited risks they are taking team-hardware-wallets type-bug Something isn't working
Projects
Bugs by severity
Status: To be fixed
Bugs by team
Status: To be fixed
Milestone
No milestone
4 participants
@dawnseeker8 @metamaskbot @angelcheung22 @vivek-consensys