Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add e2e for re-designed personal sign pages #13052

Closed
jpuri opened this issue Jan 17, 2025 · 0 comments · Fixed by #13053
Closed

Add e2e for re-designed personal sign pages #13052

jpuri opened this issue Jan 17, 2025 · 0 comments · Fixed by #13053
Assignees
@jpuri
Labels
INVALID-ISSUE-TEMPLATE Issue's body doesn't match any issue template. release-7.40.0 Issue or pull request that will be included in release 7.40.0

Comments

@jpuri
Copy link
Contributor

jpuri commented Jan 17, 2025 •
edited
Loading

We need to add e2e for new designed personal sign page.
@metamaskbot metamaskbot added the INVALID-ISSUE-TEMPLATE Issue's body doesn't match any issue template. label Jan 17, 2025
@jpuri jpuri mentioned this issue Jan 17, 2025
Merged
7 tasks
@jpuri jpuri self-assigned this Jan 17, 2025
github-merge-queue bot pushed a commit that referenced this issue Jan 23, 2025
@jpuri
chore: Adding e2e test cases for signature pages (#13053)
c40c8fd 
## **Description**

- Adding e2e for re-designed signature pages.
- Adding new pipeline for re-designed confirmations.

## **Related issues**

Fixes: #13052
Fixes: #13054
Fixes: #13055
Fixes: #13055

## **Manual testing steps**
NA

## **Screenshots/Recordings**
NA

## **Pre-merge author checklist**

- [X] I’ve followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile
Coding
Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [X] I've completed the PR template to the best of my ability
- [X] I’ve included tests if applicable
- [X] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [X] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
@metamaskbot metamaskbot added the release-7.40.0 Issue or pull request that will be included in release 7.40.0 label Jan 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jpuri jpuri

Labels
INVALID-ISSUE-TEMPLATE Issue's body doesn't match any issue template. release-7.40.0 Issue or pull request that will be included in release 7.40.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: Adding e2e test cases for signature pages MetaMask/metamask-mobile
2 participants
@jpuri @metamaskbot