Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: Smart transaction publish hook, falling back to regular transaction submission #12848

Closed
cryptodev-2s opened this issue Jan 7, 2025 · 0 comments · Fixed by #12846
Closed

[Bug]: Smart transaction publish hook, falling back to regular transaction submission #12848

cryptodev-2s opened this issue Jan 7, 2025 · 0 comments · Fixed by #12846
Labels
regression-develop Regression bug that was found on main branch, but not yet present in production release-7.40.0 Issue or pull request that will be included in release 7.40.0 type-bug Something isn't working

Comments

@cryptodev-2s
Copy link
Contributor

cryptodev-2s commented Jan 7, 2025 •
edited
Loading

Describe the bug

Smart transaction publish hook, is falling back to regular transaction submission

Expected behavior

No response

Screenshots/Recordings

No response

Steps to reproduce

  1. Enable smart transactions.
  2. Make any transaction with fees.
  3. getFees step will fail with the described error.

Error messages or log output

Error: Action missing from allow list: NetworkController:getState

Detection stage

On main branch

Version

7.37.1

Build type

None

Device

Iphone 15 Pro

Operating system

iOS

Additional context

No response

Severity

No response
@cryptodev-2s cryptodev-2s added the type-bug Something isn't working label Jan 7, 2025
@metamaskbot metamaskbot added the regression-develop Regression bug that was found on main branch, but not yet present in production label Jan 7, 2025
@cryptodev-2s cryptodev-2s mentioned this issue Jan 7, 2025
Merged
7 tasks
@github-project-automation github-project-automation bot moved this to To be fixed in Bugs by severity Jan 7, 2025
@github-project-automation github-project-automation bot moved this to To be fixed in Bugs by team Jan 7, 2025
github-merge-queue bot pushed a commit that referenced this issue Jan 9, 2025
@cryptodev-2s
fix: Add missing allowed action to the SmartTransactionsController …
5a88fca 
…messenger (#12846)

Add missing allowed action `NetworkController:getState` to the
`SmartTransactionsController` messenger.

This fixes and error in smart transaction publish hook, falling back to
regular transaction submission
`Error: Action missing from allow list: NetworkController:getState`.


<!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->

## **Description**

<!--
Write a short description of the changes included in this pull request,
also include relevant motivation and context. Have in mind the following
questions:
1. What is the reason for the change?
2. What is the improvement/solution?
-->

## **Related issues**

Fixes: #12848

## **Manual testing steps**

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**

<!-- [screenshots/recordings] -->

### **After**

<!-- [screenshots/recordings] -->

## **Pre-merge author checklist**

- [x] I’ve followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile
Coding
Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [ ] I've completed the PR template to the best of my ability
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
@github-project-automation github-project-automation bot moved this from To be fixed to Fixed in Bugs by team Jan 9, 2025
@metamaskbot metamaskbot added the release-7.40.0 Issue or pull request that will be included in release 7.40.0 label Jan 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
regression-develop Regression bug that was found on main branch, but not yet present in production release-7.40.0 Issue or pull request that will be included in release 7.40.0 type-bug Something isn't working
Projects
Bugs by severity
Archived in project
Bugs by team
Status: Fixed
Milestone
No milestone
2 participants
@metamaskbot @cryptodev-2s