Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: infura Goerli and linea goerli should be removed from the network controller state #12837

Closed
1 of 9 tasks
salimtb opened this issue Jan 6, 2025 · 0 comments · Fixed by #12838
Closed
1 of 9 tasks

[Bug]: infura Goerli and linea goerli should be removed from the network controller state #12837

salimtb opened this issue Jan 6, 2025 · 0 comments · Fixed by #12838
Labels
release-7.40.0 Issue or pull request that will be included in release 7.40.0

Comments

@salimtb
Copy link
Contributor

salimtb commented Jan 6, 2025 •
edited by NicolasMassart
Loading

What is this about?

The Infura networks for Goerli and Linea Goerli should no longer be included in the network controller state. These networks no longer supported by Infura

Scenario

  • start locally the app
  • check the logs
Image

Design

No response

Technical Details

No response

Threat Modeling Framework

No response

Acceptance Criteria

No response

Stakeholder review needed before the work gets merged

  • Engineering (needed in most cases)
  • Design
  • Product
  • QA (automation tests are required to pass before merging PRs but not all changes are covered by automation tests - please review if QA is needed beyond automation tests)
  • Security
  • Legal
  • Marketing
  • Management (please specify)
  • Other (please specify)

References

No response
@salimtb salimtb mentioned this issue Jan 6, 2025
Merged
7 tasks
github-merge-queue bot pushed a commit that referenced this issue Jan 9, 2025
@salimtb
fix: remove goerli infura from network state (#12838)
2215339 
<!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->

## **Description**

core PR: MetaMask/core#5094
<!--
Write a short description of the changes included in this pull request,
also include relevant motivation and context. Have in mind the following
questions:
1. What is the reason for the change?
2. What is the improvement/solution?
-->

## **Related issues**

Fixes: #12837

## **Manual testing steps**

1. Run the app locally
2. you should not see the verbose logs , or any request sent to Goerli

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**

<!-- [screenshots/recordings] -->

### **After**

<!-- [screenshots/recordings] -->

## **Pre-merge author checklist**

- [ ] I’ve followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile
Coding
Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [ ] I've completed the PR template to the best of my ability
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
@metamaskbot metamaskbot added the release-7.40.0 Issue or pull request that will be included in release 7.40.0 label Jan 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
release-7.40.0 Issue or pull request that will be included in release 7.40.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: remove goerli infura from network state MetaMask/metamask-mobile
2 participants
@salimtb @metamaskbot