chore(js-ts): Convert app/util/streams to TypeScript #11398
Conversation
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
devin-ai-integration
bot
added
needs-dev-review
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
|
New dependencies detected. Learn more about Socket for GitHub ↗︎
|
There was a problem hiding this comment.
I would expect a unit test written for this refactor so that we can have one passing before, in JS, then have to modify it after TS migration and be able to check that it only requires typing changes and no functional changes. Here we can't automatically check that this is not breaking something aside by running all the unit tests.
TS migration is a good opportunity to increase coverage to me, and I guess AI knows how to write tests pretty well.
There was a problem hiding this comment.
C: It's a shame that it did not make it as a rename so that we could see both JS and TS side by side instead of delete and new.
There was a problem hiding this comment.
Unfortunately, we're at the will of how Github diff analyzes the changes
There was a problem hiding this comment.
It does it fine in https://github.com/MetaMask/metamask-mobile/pull/11335/files so not sure why here it doesn't see the renaming
devin-ai-integration
bot
added
the
skip-sonar-cloud
|
Triggering CI rerun |
|
|
This PR has been automatically marked as stale because it has not had recent activity in the last 90 days. It will be closed in 7 days. Thank you for your contributions. |
github-actions
bot
added
the
stale
|
This PR was closed because there has been no follow up activity in 7 days. Thank you for your contributions. |
PR Title
chore(js-ts): Convert app/util/streams to TypeScript
Description
This PR converts the
streams.jsfile in theapp/utildirectory to TypeScript, resulting in the newstreams.tsfile. The conversion process involved adding type annotations, ensuring compatibility with TypeScript, and removing the old.jsfile.Motivation
The conversion to TypeScript enhances type safety, improves code maintainability, and aligns with the project's goal of migrating to TypeScript.
Changes
streams.jstostreams.tswith appropriate type annotations.streams.jsfile.@types/pumpand@types/through2as dev dependencies to thepackage.jsonfile.Context
The conversion process followed the detailed procedure provided, ensuring all TypeScript and linting checks pass without errors. The
through2package is used for creating transform streams, and thepumppackage is used for stream piping.Labels
Additional Notes
This PR was requested by Moritz. Please review the changes and let me know if there are any questions or further adjustments needed.
Devin Run
This Devin run was requested by Moritz.
If you have any feedback, you can leave comments in the PR and I'll address them in the app!