MetaMask on-boarding lib not working within another extension using MetaMask extension-provider

[Tedko]

What problem are you trying to solve?

Please refer to MetaMask/extension-provider#9

In short

the onboarding library doesn't work for another web extension.

https://github.com/MetaMask/metamask-onboarding/blob/master/src/index.ts#L154

In this line, you detect metamask by window.ethereum.isMetaMask but window.ethereum is not available in the web extension. This is why I'm using extension-provider . There should be other browser APIs could do so (some communication between extensions)

For What's Maskbook:

#8593
MetaMask/metamask-snaps-beta#62

Describe the solution you'd like
another extension know if Metamask is already installed (so we can have things similar to onboarding lib etc)

Additional context

How maskbook extension is using MetaMask (we can also send red packet etc / call smart contract right on top of twitter./fb)

[Tedko]

@danfinlay thx for helping

[Tedko]

@Jack-Works Lets stick on this issue

[Tedko]

I believe this is fixed(?) not using on-boarding lib though