Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: CCIP Read ENS resolution fails #27784

Open
Gudahtt opened this issue Oct 11, 2024 · 2 comments
Open

[Bug]: CCIP Read ENS resolution fails #27784

Gudahtt opened this issue Oct 11, 2024 · 2 comments
Assignees
Labels
regression-prod-12.1.1 Regression bug that was found in production in release 12.1.1 Sev2-normal Normal severity; minor loss of service or inconvenience. team-identity team-wallet-api-platform team-wallet-framework type-bug

Comments

@Gudahtt
Copy link
Member

Gudahtt commented Oct 11, 2024

Describe the bug

Originally reported in MetaMask/eth-json-rpc-middleware#335:

ENS resolution sometimes uses CCIP read (eip-3668) to resolve an address.
That relies on a reverted execution being interpreted as a redirect.
When the provider used to perform such a read is managed by this middleware, the read operation fails.
My guess is that the reverted execution is somehow wrapped such that the error is no longer interpretable.

Expected behavior

ENS resolution should succeed, including addresses that use CCIP read.

Screenshots/Recordings

No response

Steps to reproduce

  1. Checkout the test-app repository locally to the ens-resolution branch (see feat: Add ENS resolution test-dapp#362)
  2. Start the test dapp using yarn start
  3. Install the MetaMask extension (any type of build)
  4. Ensure that the current selected chain is Ethereum Mainnet
  5. Navigate to the locally-hosted test dapp and connect at least one account
  6. Scroll to the bottom, enter jwt.ro into the "ENS Resolution" field, then click Submit

This should resolve to an address, but it currently resolves to null instead.

Error messages or log output

No response

Detection stage

In production (default)

Version

12.1.1

Build type

None

Browser

Chrome

Operating system

MacOS

Hardware wallet

No response

Additional context

No response

Severity

No response

@Gudahtt Gudahtt added type-bug Sev2-normal Normal severity; minor loss of service or inconvenience. regression-prod-12.1.1 Regression bug that was found in production in release 12.1.1 labels Oct 11, 2024
@FrederikBolding
Copy link
Member

@Gudahtt We'll need #22875

Blocked by:
MetaMask/core#4773
#24496
#27700

@snackman
Copy link

plz fiz this, PizzaDAO needs you. We'll buy pizza for whoever does it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
regression-prod-12.1.1 Regression bug that was found in production in release 12.1.1 Sev2-normal Normal severity; minor loss of service or inconvenience. team-identity team-wallet-api-platform team-wallet-framework type-bug
Projects
Status: To be fixed
Status: To be fixed
Development

No branches or pull requests

4 participants