Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve TokenBalancesController with new polling patterns and optimizations #4761

Open
bergeron opened this issue Oct 4, 2024 · 0 comments
Open

Improve TokenBalancesController with new polling patterns and optimizations #4761

bergeron opened this issue Oct 4, 2024 · 0 comments
Labels
team-assets

Comments

@bergeron
Copy link
Contributor

bergeron commented Oct 4, 2024

  • Make TokenBalancesController extend StaticIntervalPollingController
  • Update the state to be per chain id and per account
  • Make it use AssetsContractController:getBalancesInSingleCall to more efficiently get balances in 1 RPC call if the chain supports it
  • If the chain does not have our multicall contract, fetch balances in parallel
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
team-assets
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@desi @bergeron