Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add connected_from uri column to the export #367

Closed
ddelpiano opened this issue Nov 27, 2024 · 17 comments
Closed

add connected_from uri column to the export #367

ddelpiano opened this issue Nov 27, 2024 · 17 comments

Comments

@ddelpiano
Copy link
Member

acceptance criteria:

  • add another column for connected_from called connected_from_uris which will list the URIs instead of the rdfs names of the entities.
  • @stappan please include any other change of column names, order of the columns or other that you would like us to work on. Thx
@stappan
Copy link
Collaborator

stappan commented Dec 5, 2024

@ddelpiano here's the new export template: export template

Let me know if you have questions? In this export, only rows that have data should be exported. Items that are free text (alerts, statement preview) will have an Object text, but not an object URI since they are annotations.

@stappan
Copy link
Collaborator

stappan commented Dec 5, 2024

Please use column labels as provided in Export template above, I filled in a mock-population to show the values that could be exported...i hope that makes sense.

@ddelpiano
Copy link
Member Author

@ddelpiano here's the new export template: export template

Let me know if you have questions? In this export, only rows that have data should be exported. Items that are free text (alerts, statement preview) will have an Object text, but not an object URI since they are annotations.

Hi @stappan few notes:

  • the ID in the first column is an information that is not available at the moment, this would require to modify the ingestion. It cannot fit this sprint since the original scope of this card was to change column names and shift the order, let me know if you want me to open a separate request for this.
  • first row contains a predicate we've never seen (composerGenLabel), is this for a future request?
  • Predicate URI is not an information we hold currently in the model, we only have the predicate, I can open a separate card to support the Predicate URI as part of the current mapping exists for the export, let me know.
  • Direct Experimental Evidence, Expert Inference, Expert Knowledge, Indirect Experimental Evidence, Laterality Difference, Not relevant - Could you please tell us what these columns should give you? Again, we can open a separate ticket for this.

Thanks.

@stappan
Copy link
Collaborator

stappan commented Dec 9, 2024

@ddelpiano @gidili how many hours will it take to actually get what i want here?

@stappan
Copy link
Collaborator

stappan commented Dec 9, 2024

@ddelpiano the predicate, composerGenLabel, is to support the export of the statement preview. see #312 which was also in this sprint.

@stappan
Copy link
Collaborator

stappan commented Dec 9, 2024

@ddelpiano Direct Experimental Evidence, Expert Inference, Expert Knowledge, Indirect Experimental Evidence, Laterality Difference, Not relevant - Could you please tell us what these columns should give you? Again, we can open a separate ticket for this.
these are already exported by Composer. no changes needed, other than match the position I placed them in.

@stappan
Copy link
Collaborator

stappan commented Dec 9, 2024

@ddelpiano for the first column , it's simply
image
Do you need to store it? or just compute it?

@ddelpiano
Copy link
Member Author

@ddelpiano the predicate, composerGenLabel, is to support the export of the statement preview. see #312 which was also in this sprint.

#312 refers to a new column not a new row. Thanks

@ddelpiano
Copy link
Member Author

@ddelpiano Direct Experimental Evidence, Expert Inference, Expert Knowledge, Indirect Experimental Evidence, Laterality Difference, Not relevant - Could you please tell us what these columns should give you? Again, we can open a separate ticket for this. these are already exported by Composer. no changes needed, other than match the position I placed them in.

I would assume these are coming from the tags then, for the order at the moment it depends by the order these have been created. If what provided is the same of what was before there should be no changes required, otherwise we need to extend the mapping to the tags, I don't have clear estimate for this since I need to look into what can be done to manipulate the order of something that is dynamically created through the admin interface (and so the backend does not know about its existence).

@ddelpiano
Copy link
Member Author

@ddelpiano for the first column , it's simply image Do you need to store it? or just compute it?

it needs to be stored from neurondm since it's not always consistent in the number of strings at the end of the URI that are making the id, e.g. http://uri.interlex.org/tgbugs/uris/readable/neuron-type-bolew-unbranched-2 it's only the last one where http://uri.interlex.org/tgbugs/uris/readable/femrep/60 are the last 2 strings of the uri.

@stappan
Copy link
Collaborator

stappan commented Dec 9, 2024

@ddelpiano Direct Experimental Evidence, Expert Inference, Expert Knowledge, Indirect Experimental Evidence, Laterality Difference, Not relevant - Could you please tell us what these columns should give you? Again, we can open a separate ticket for this. these are already exported by Composer. no changes needed, other than match the position I placed them in.

I would assume these are coming from the tags then, for the order at the moment it depends by the order these have been created. If what provided is the same of what was before there should be no changes required, otherwise we need to extend the mapping to the tags, I don't have clear estimate for this since I need to look into what can be done to manipulate the order of something that is dynamically created through the admin interface (and so the backend does not know about its existence).

Ah, yes, those are tags that have the checkbox to be included in export. The order doesn't matter at this time. I've opened a ticket for the backlog about improving visibility in the admin interface: #375

@stappan
Copy link
Collaborator

stappan commented Dec 9, 2024

@ddelpiano for the first column , it's simply image Do you need to store it? or just compute it?

it needs to be stored from neurondm since it's not always consistent in the number of strings at the end of the URI that are making the id, e.g. http://uri.interlex.org/tgbugs/uris/readable/neuron-type-bolew-unbranched-2 it's only the last one where http://uri.interlex.org/tgbugs/uris/readable/femrep/60 are the last 2 strings of the uri.

Wouldn't this just be able to be done by parsing anything past /readable/ and any / after "readable/" is a dash?

@stappan
Copy link
Collaborator

stappan commented Dec 9, 2024

@ddelpiano the predicate, composerGenLabel, is to support the export of the statement preview. see #312 which was also in this sprint.

#312 refers to a new column not a new row. Thanks

It's the statement preview (see column H). In the current export, there was a mismash of columns that would just continue to expand willy-nilly as the software expanded it's functionality. This organization of making a row for each triple ensures the number of columns is more stable from release to release. Does this make sense?

@stappan
Copy link
Collaborator

stappan commented Dec 9, 2024

I created a new ticket for the predicate URIs here: #373

@ddelpiano
Copy link
Member Author

@ddelpiano for the first column , it's simply image Do you need to store it? or just compute it?

it needs to be stored from neurondm since it's not always consistent in the number of strings at the end of the URI that are making the id, e.g. http://uri.interlex.org/tgbugs/uris/readable/neuron-type-bolew-unbranched-2 it's only the last one where http://uri.interlex.org/tgbugs/uris/readable/femrep/60 are the last 2 strings of the uri.

Wouldn't this just be able to be done by parsing anything past /readable/ and any / after "readable/" is a dash?

If you prefer yes but we cannot guarantee then on the integrity of the id since the translation from slash to dash could be changed or could use different rules in certain cases. If you are ok with that we can generate this from the url.

@stappan
Copy link
Collaborator

stappan commented Dec 10, 2024

@ddelpiano yep you're totally right. thanks! - i discussed with @tgbugs - you should import the rdfs:label from neurondm for the neuron populations
Should i create a new request - or should it be added to #373 ?

@ddelpiano
Copy link
Member Author

@stappan I am closing this card since the original requirements have been addressed and the new requests have been captured by #387 , #385 and #373 . Feel free to reopen this if you feel something has been forgot here. Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants