Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/18 #20

Merged
merged 10 commits into from
Aug 1, 2022
Merged

Feature/18 #20

merged 10 commits into from
Aug 1, 2022

Conversation

ddelpiano
Copy link
Member

No description provided.

@ddelpiano ddelpiano requested a review from afonsobspinto July 28, 2022 20:59
@ddelpiano ddelpiano linked an issue Jul 28, 2022 that may be closed by this pull request
@ddelpiano ddelpiano self-assigned this Jul 28, 2022
Copy link
Contributor

@zsinnema zsinnema left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@afonsobspinto can you please fix the merge conflicts? thanks

@afonsobspinto
Copy link
Member

Yes, I will have a look later. Some of my commits were not meant to be merged into dev but rather to ease development for @vidhya-metacell.
Specifically, I don't think we need the props renaming, nor the react-diagrams components exposing.
I will check with @ddelpiano and do the changes myself according to his reply.

@afonsobspinto afonsobspinto merged commit 598cdb6 into develop Aug 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add key to instances generated by the factories
3 participants