Feature/45 Right Sidebar Frontend implementation #57
Conversation
emekauja
commented
Oct 20, 2022
•
emekauja
commented
src/components/Main.js
Outdated
|
|
||
| const mockModel = require('../resources/model').mockModel; | ||
|
|
||
| const styles = () => ({ | ||
| root: { | ||
| height: 'calc(100vh - 3.5rem)', | ||
| width: '100%', | ||
| margin: 'none', |
There was a problem hiding this comment.
@emekauja margin and padding values are not working, also i don't see the value add even id they were.
| return ( | ||
| <> | ||
| <Box paddingLeft="1.5rem" paddingY={1.5}> | ||
| <Typography component="body2" fontWeight={500}> |
There was a problem hiding this comment.
@emekauja body2 is a variant, not a component, hence no properties of body2 are reflecting
| if (datasets?.length > 0) { | ||
| return ( | ||
| <> | ||
| <Box paddingLeft="1.5rem" paddingY={1.5}> |
There was a problem hiding this comment.
@emekauja Incorrect padding should be an px passing instead of just left. Left would 2 not 1.5, so px={2}
|
Hi @emekauja , i reviewed the UI of the sidebar, found the following issues:
|
|
@emekauja found the following issues with font properties
|
There was a problem hiding this comment.
There is another problem noticed testing the sidebar.
If I click on the first composition and then try to compress this, the compression does not work unless I play with another item of the sidebar (deadlock in the state?), please fix this.
scrnli_01_11_2022_10-12-55.mp4
Other than this there are the changes requested by Vidhya and then this can be approved.
Thanks!
| return; | ||
| } | ||
|
|
||
| // if (nodes.length !== nodeIds.length && nodes[0] === nodeIds[0]) { |
There was a problem hiding this comment.
@emekauja please remove commented code if not used
…used across all application modals
