Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Composition component prototype #36

Open
ddelpiano opened this issue Jul 18, 2022 · 0 comments
Open

Composition component prototype #36

ddelpiano opened this issue Jul 18, 2022 · 0 comments

Comments

@ddelpiano
Copy link
Member

ddelpiano commented Jul 18, 2022 •
edited
Loading

As per last call, the composition will be visualised as a square that contains all the nodes inside.
We need to prototype this component, keeping in mind that:

  • when we drag and drop the compositions all the content will move with it.
  • I can still drag and drop any single node inside
  • if a node gets dropped outside the composition then it's not part of that anymore.

The focus of this card is more on the functional side rather than the concept of composition itself within psyneulink, so the 3 key points above are the things that we should focus implementation wise.
@zsinnema zsinnema transferred this issue from MetaCell/PsyNeuLinkViewSource Jul 26, 2022
ddelpiano added a commit that referenced this issue Sep 5, 2022
@ddelpiano
#36 composition implementation, metanode instantiation and pluggin re…
2d2d5de 
…quired parts of the library
ddelpiano added a commit that referenced this issue Sep 7, 2022
@ddelpiano
#36 removed modelMap
cc20d77
ddelpiano added a commit that referenced this issue Sep 7, 2022
@ddelpiano
#36 more on the composition implementation
80f8911
ddelpiano added a commit that referenced this issue Oct 6, 2022
@ddelpiano
#36 frontend model interpreter refactoring
feb3dd0
@afonsobspinto afonsobspinto removed their assignment Oct 24, 2022
ddelpiano added a commit that referenced this issue Oct 25, 2022
@ddelpiano
#36 moving logic from graph to children for metanodes
13e18e4
ddelpiano added a commit that referenced this issue Oct 25, 2022
@ddelpiano
#36 new interface for ExtraObject
e216cf9
ddelpiano added a commit that referenced this issue Oct 25, 2022
@ddelpiano
#36 handling parent child relationship and moving logic out of meta-d…
556b1eb 
…iagram
ddelpiano added a commit that referenced this issue Oct 25, 2022
@ddelpiano
#36 parent child relationship logic moved to application
1e1b144
@zsinnema zsinnema mentioned this issue Oct 26, 2022
Merged
ddelpiano added a commit that referenced this issue Oct 28, 2022
@ddelpiano
#36 adding logic for the new path calculation
256d0c8
ddelpiano added a commit that referenced this issue Oct 28, 2022
@ddelpiano
#36 workin on the child set position event propagation
aacde89
ddelpiano added a commit that referenced this issue Oct 28, 2022
@ddelpiano
#36 sync parent children on position updates
3580b54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@afonsobspinto @ddelpiano