Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improving UX by hiding editing buttons for readers of a project #3682

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

VitorVieiraZ
Copy link
Contributor

@VitorVieiraZ VitorVieiraZ commented Nov 18, 2024

While in Reader role, editing buttons are no longer visible to user. These buttons include:

Main Add button and the one within the features list.
Add feature button and its variations.
Edit feature button and its variations.
Edit geometry button.

Reader Other Roles

Resolves #3174

Copy link

github-actions bot commented Nov 27, 2024

Pull Request Test Coverage Report for Build 12256026569

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 180 unchanged lines in 3 files lost coverage.
  • Overall coverage increased (+0.04%) to 60.392%

Files with Coverage Reduction New Missed Lines %
input/core/merginprojectmetadata.cpp 3 88.64%
input/app/activeproject.cpp 65 69.45%
input/core/merginapi.cpp 112 78.08%
Totals Coverage Status
Change from base Build 12135499446: 0.04%
Covered Lines: 7918
Relevant Lines: 13111

💛 - Coveralls

@VitorVieiraZ VitorVieiraZ changed the title WIP - Improving UX by hiding editing buttons for readers and guests of a project Improving UX by hiding editing buttons for readers and guests of a project Dec 10, 2024
@VitorVieiraZ VitorVieiraZ changed the title Improving UX by hiding editing buttons for readers and guests of a project Improving UX by hiding editing buttons for readers of a project Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Users unable to sync project after a reader user makes some local changes
2 participants