-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PDF Viewing Feature #3353
PDF Viewing Feature #3353
Conversation
Please merge master branch here to make CI working. We can then proceed with testing |
a054678
to
6d3a73e
Compare
6d3a73e
to
a19c0ed
Compare
Pull Request Test Coverage Report for Build 9207444860Details
💛 - Coveralls |
Windows build is failing here @VitorVieiraZ, please check the error log |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one small comment, otherwise it looks good :)
Let's merge to master and then test from there |
I just tried this feature on the APK from this ticket and I always get an error message, that the file does not exist. Can you please check it? My project is tc05_forms_derived and there is a tab called |
Tests successfully conducted. In the case of a file inside a folder in the project directory, use the following format:
sample.pdf file inside 'files' folder |
@VitorVieiraZ I checked the project and I don't see a problem in the configuration. Do you see it? I tried it again and I was able to open TXT and DOCX files, but the PDF file was still unavailable. Screen_Recording_20240514_094720_My.Files.mp4 |
b8b854b
to
829c476
Compare
Now it looks great! I didn't find any more problems. |
Unfortunately, the files in sub-directories stopped working Screen_Recording_20240515_230806.mp4 |
@VitorVieiraZ please merge master branch here - it will upload the build to iOS then too :) |
@jozef-budac Can you please retest this PR? We are mainly interested in PDFs so if they work we can merge it and fix other file types later. This is the build to test it with: https://github.com/MerginMaps/mobile/actions/runs/9158230910?pr=3353 |
4376c5a
to
d3293db
Compare
@jozef-budac you can now test it on iOS too :) |
24.5.622711 |
I can confirm that the |
It says |
After removing these two lines mobile/cmake_templates/AndroidManifest.xml.in Lines 110 to 111 in d3293db
the code works as expected for me in the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@VitorVieiraZ Can you please remove these two lines
mobile/cmake_templates/AndroidManifest.xml.in
Lines 110 to 111 in d3293db
<action android:name="android.intent.action.OPEN_DOCUMENT" /> | |
<action android:name="android.intent.action.GET_CONTENT" /> |
PDF files are working now of both Android and iOS> |
For me all of them worked :)
…On Thu, 23 May 2024 at 14:39, Jozef Budáč ***@***.***> wrote:
PDF files are working now.
The docx and xlsx are not. But if only PDF is mandatory, we can go with
this to production
—
Reply to this email directly, view it on GitHub
<#3353 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AFLI4IRKLZ744SVUKYZLMCDZDXPONAVCNFSM6AAAAABGUMKYDOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMRXGAYDKMRWG4>
.
You are receiving this because your review was requested.Message ID:
***@***.***>
|
Here is a video from Android 14 Screen_Recording_20240523_145441.mp4 |
@jozef-budac do you have some app to open xls installed? If yes, we can debug then. Anyways,let's merge it as pdfs are working now :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀 🔥
@tomasMizera Yes I have programs to open such files. In some of the previous APKs I was able to open the files. I wrote a note "Now it looks great! I didn't find any more problems." But then it doesn't work anymore. |
This feature can be used to open PDF files using the user’s system default application viewer, and can open formats such as links, PDFs, Docx, etc.
-
'<a href="project://dummy.pdf">Open File</a>'
(include the HTML code inside single quotes).-
<a href="project://dummy.pdf">Open File</a>
(able to enter the HTML code without quotes).<a href="project://files/sample.pdf">Open PDF File inside folder "files"</a>
sample.pdf file inside 'files' folder
<a href="https://www.qgis.org/">Visit QGIS</a>