Attempt to fix locationManager crash on Android (#2803)

* Call parent destructor as the last thing * Check if locationManager is validbefore removing updates
MerginMaps · Sep 25, 2023 · c4f72ab · c4f72ab
1 parent 2bf06a4
commit c4f72ab
Showing 1 changed file with 5 additions and 2 deletions.
diff --git a/app/android/src/uk/co/lutraconsulting/PositionTrackingService.java b/app/android/src/uk/co/lutraconsulting/PositionTrackingService.java
@@ -83,9 +83,10 @@ public IBinder onBind( Intent intent ) {
 
     @Override
     public void onDestroy() {
-        super.onDestroy();
 
-        locationManager.removeUpdates(this);
+        if (locationManager != null) {
+            locationManager.removeUpdates(this);
+        }
 
         // Close the FileOutputStream when the service is destroyed
         try {
@@ -96,6 +97,8 @@ public void onDestroy() {
             e.printStackTrace();
             sendStatusUpdateMessage("ERROR #SILENT: Could not close file stream: " + e.getMessage() );
         }
+
+        super.onDestroy();
     }
 
     public void sendStatusUpdateMessage( String message ) {