Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Emails troubleshooting #532

Open
wants to merge 16 commits into
base: main
Choose a base branch
from
Open

Emails troubleshooting #532

wants to merge 16 commits into from
+48 −16

Conversation

MarcelGeo
Copy link
Contributor

Added:

  • emails are not send section to server troubleshooting
  • updates in env variables

@MarcelGeo
Added:
2698372 
- emails are not send section to server troubleshooting
- updates in env variables
@MarcelGeo MarcelGeo requested a review from tomasMizera December 3, 2024 13:10
tomasMizera
tomasMizera reviewed Dec 3, 2024
View reviewed changes
Copy link
Contributor

@tomasMizera tomasMizera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @alex-cit, can I ask you to fix/rephrase grammar here? Thanks!

src/server/troubleshoot/index.md Outdated Show resolved Hide resolved
alex-cit
alex-cit reviewed Dec 6, 2024
View reviewed changes
Copy link
Contributor

@alex-cit alex-cit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! I added some suggestions (I hope they don't change the meaning of the instructions :) )

src/server/administer/environment.md Outdated Show resolved Hide resolved
src/server/install/index.md Outdated Show resolved Hide resolved
src/server/troubleshoot/index.md Outdated Show resolved Hide resolved
src/server/troubleshoot/index.md Outdated Show resolved Hide resolved
src/server/troubleshoot/index.md Outdated Show resolved Hide resolved
src/server/troubleshoot/index.md Outdated Show resolved Hide resolved
src/server/troubleshoot/index.md Outdated Show resolved Hide resolved
src/server/troubleshoot/index.md Outdated Show resolved Hide resolved
src/server/troubleshoot/index.md Outdated Show resolved Hide resolved
src/server/troubleshoot/index.md Outdated Show resolved Hide resolved
varmar05
varmar05 requested changes Dec 9, 2024
View reviewed changes
src/server/administer/environment.md Show resolved Hide resolved
src/server/troubleshoot/index.md Outdated Show resolved Hide resolved
src/server/troubleshoot/index.md Outdated Show resolved Hide resolved
src/server/troubleshoot/index.md Show resolved Hide resolved
@varmar05

This comment was marked as resolved.

Sign in to view
MarcelGeo and others added 12 commits December 9, 2024 09:58
@MarcelGeo @alex-cit
Suggestion - Update src/server/troubleshoot/index.md
db555ed 
Co-authored-by: Alexandra Bucha Rasova <[email protected]>
@MarcelGeo @alex-cit
Suggestion - Update src/server/troubleshoot/index.md
0ec93bb 
Co-authored-by: Alexandra Bucha Rasova <[email protected]>
@MarcelGeo @alex-cit
Suggestion - Update src/server/administer/environment.md
3a7a121 
Co-authored-by: Alexandra Bucha Rasova <[email protected]>
@MarcelGeo @alex-cit
Suggestion - Update src/server/install/index.md
852c528 
Co-authored-by: Alexandra Bucha Rasova <[email protected]>
@MarcelGeo @alex-cit
Suggestion - Update src/server/troubleshoot/index.md
d8ceca5 
Co-authored-by: Alexandra Bucha Rasova <[email protected]>
@MarcelGeo @alex-cit
Update src/server/troubleshoot/index.md
883e44b 
Co-authored-by: Alexandra Bucha Rasova <[email protected]>
@MarcelGeo @alex-cit
Update src/server/troubleshoot/index.md
3e98245 
Co-authored-by: Alexandra Bucha Rasova <[email protected]>
@MarcelGeo @alex-cit
Update src/server/troubleshoot/index.md
41960da 
Co-authored-by: Alexandra Bucha Rasova <[email protected]>
@MarcelGeo @alex-cit
Update src/server/troubleshoot/index.md
14bcaa4 
Co-authored-by: Alexandra Bucha Rasova <[email protected]>
@MarcelGeo @alex-cit
Update src/server/troubleshoot/index.md
5295e59 
Co-authored-by: Alexandra Bucha Rasova <[email protected]>
@MarcelGeo
Rename SaaS
9627610
@MarcelGeo
Add example from celery with sending emails @alex-cit @varmar05
a17db4d
@MarcelGeo
Copy link
Contributor Author

@MarcelGeo let's make sure we address typical issues

* celery worker container crashing - generic config issue (e.g. RUN_CELERY legacy issues)

* celery worker process not working / stuck - generic config issue (e.g. MONKEY_PATCH issue)

* email not processed - probably not sent to queue by flask (mail config issue)

* email processed (success in logs) but no email received - SMTP config issue

added success scenario for emails. Celery troubleshooting will be another task.

@MarcelGeo
Copy link
Contributor Author

@alex-cit review new changes and we can merge It :)

alex-cit
alex-cit approved these changes Dec 13, 2024
View reviewed changes
Copy link
Contributor

@alex-cit alex-cit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! I have left some suggestions

src/server/administer/environment.md
| `MAIL_PASSWORD` | string | `None` | Password for user connecting to SMTP server. |
| `MAIL_USE_TLS`🛡️ | Boolean | `true` | Use TLS encryption when connecting to SMTP server. |
| `MAIL_USE_SSL`🛡️ | Boolean | `false` | Whether to use SSL encryption when connecting to SMTP server. |
| `MAIL_BCC` | string | `None` | Email address to send copies of all emails. sent. Should be system/application administrator. Mandatory in versions until 2024.4.0 |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
| `MAIL_BCC` | string | `None` | Email address to send copies of all emails. sent. Should be system/application administrator. Mandatory in versions until 2024.4.0 |
| `MAIL_BCC` | string | `None` | Email address to send copies of all sent emails. Should be system/application administrator. Mandatory in versions until 2024.4.0. |

src/server/install/index.md
@@ -43,4 +44,4 @@ $ docker exec merginmaps-server flask user create <username> <password> --is-adm

### Setup environment
​
Now tweak deployment settings by modifying environment variables. You have to fix all variables marked as `fixme` (with asterisks) in this list of [environment variables](../administer/environment.md).
Now tweak deployment settings by modifying environment variables. You have to fix all variables marked as required in this list of [environment variables](../administer/environment.md). In [troubleshoot](../troubleshoot/index.md) section are listed some of the most common issues with custom deployments.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Now tweak deployment settings by modifying environment variables. You have to fix all variables marked as required in this list of [environment variables](../administer/environment.md). In [troubleshoot](../troubleshoot/index.md) section are listed some of the most common issues with custom deployments.
Now tweak deployment settings by modifying environment variables. You have to fix all variables marked as required in this list of [environment variables](../administer/environment.md). Some of the most common issues with custom deployments are listed in the [troubleshoot](../troubleshoot/index.md) section.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomasMizera tomasMizera tomasMizera left review comments

@alex-cit alex-cit alex-cit approved these changes

@varmar05 varmar05 Awaiting requested review from varmar05

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@MarcelGeo @varmar05 @tomasMizera @alex-cit