Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: special characters in password cause authentication failures #281

Closed
pnadolny13 opened this issue Oct 25, 2024 · 0 comments · Fixed by #282
Closed

bug: special characters in password cause authentication failures #281

pnadolny13 opened this issue Oct 25, 2024 · 0 comments · Fixed by #282

Comments

@pnadolny13
Copy link
Contributor

Related to https://github.com/snowflakedb/snowflake-sqlalchemy?tab=readme-ov-file#escaping-special-characters-such-as---signs-in-passwords. The tap will hit authentication failures if the password has special characters in it. Sqlalchemy suggests that they be encoded using:

import urllib.parse
urllib.parse.quote("kx@% jj5/g")

One backwards compatibility thing is that some users may have already hit this and manually encoded their password. In that case we shouldnt double encode it. We could attempt a login and if authentication fails, attempt a second login with the encoded version of the password or just bump the release version and warn of a change to the defaults.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant