Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[🐞]: Valhelsia Furniture recipes ignoring sticks #740

Closed
4 tasks done
Eourist opened this issue Dec 26, 2024 · 5 comments
Closed
4 tasks done

[🐞]: Valhelsia Furniture recipes ignoring sticks #740

Eourist opened this issue Dec 26, 2024 · 5 comments
Labels
1.20.1-FORGE Minecraft Version bug Something isn't working recalcitrant won't fix or cannot solve

Comments

@Eourist
Copy link

Eourist commented Dec 26, 2024

Code of Conduct

  • Always check you are using the latest version of the mods and its dependencies
  • Remove mod that enhances Minecraft: Optifine, Sodium, others. The issue still persists.
  • If you are unsure which mod is the culprit.
    Disable all of your mods and enable them 1-2 mods each time to isolate the culprit
  • Confirm that there is no existing issue with a similar description submitted in the list of issues.

Version - Loader (DO NOT FORGET TO SELECT THE CORRECT VERSION)

1.20.1 - FORGE

EveryCompat Version

everycomp-1.20-2.7.8

Moonlight Lib Version

moonlight-1.20-2.13.42

Issue with mods

valhelsia_furniture-forge-1.20.1-1.1.3

Issue Detail

Images

The recipe for a Valhelsia Chair looks like this:
2024-12-26_12 52 06
But for some reason it's crafted even when I don't include the sticks:
2024-12-26_12 52 29
It also happens with the other recipes, the Table, Desk, and Desk Drawer:
2024-12-26_12 56 45
2024-12-26_12 52 44
2024-12-26_12 52 34

Polymorph sometimes works and allows me to craft slabs, but sometimes it doesn't, I don't understand why:
2024-12-26_12 54 38

OPTIONAL: Latest.log | Crash-report Attachment

No response

OPTIONAL: To Produce

No response

@Eourist Eourist added the bug Something isn't working label Dec 26, 2024
@github-actions github-actions bot added the 1.20.1-FORGE Minecraft Version label Dec 26, 2024
@Xelbayria
Copy link
Collaborator

Xelbayria commented Dec 26, 2024

Hmm I remember this issue. the problem is the JEI/REI/EMI. I'll find the old issue.

EDIT:
Seeing the recipe viewer you are using is a JEI. Try use REI or EMI.

@Xelbayria
Copy link
Collaborator

Found the old issue

I was discussing this issue with the DEV of EMI to find out why it happened. There are more information in the issue.

@Eourist
Copy link
Author

Eourist commented Dec 26, 2024

Tried EMI, the recipe viewer doesn't show the sticks, so now it actually matches what the crafting table does.
So if I'm understanding this correctly, there's some custom formatting in Valhelsia Furniture's recipes, which apparently JEI knows how to interpret, but not EMI or EveryComp?

@Xelbayria
Copy link
Collaborator

there's some custom formatting in Valhelsia Furniture's recipes

Correct. BUT EveryComp is not a recipe viewer. it support furniture mods that don't have support for Wood mods (Biomes O' Plenty and more). you are also correct, EMI or REI cannot interpret the condition in the recipe. Only JEI is capable of this, IIRC.

If you look at the recipe of Valhelsia Furniture (VF). it has a condition where it would be loaded depending on loader: FABRIC or FORGE.

VF is the only one I know that have a custom recipe which use condition to decide which ingredient based on the loader

@Xelbayria Xelbayria added the recalcitrant won't fix or cannot solve label Dec 29, 2024
@Xelbayria
Copy link
Collaborator

Xelbayria commented Dec 29, 2024

Alright, there is nothing I can do on my side. The issue is on Valhelsia Furniture where they use a conditional in a recipe (making it a unique recipe). EMI or REI failed to interpret that conditional and ended up ignoring it.

EMI can work with JEI. If you try to craft using the recipes, you'll find it's working fine.

BEST SOLUTION: The DEVs of EMI or REI should have update their mod to be able to interpret the conditional. You already saw the decision of EMI's DEV on the old issue I created above.

The other solution is to report the issue to DEV of Valhelsia Furniture to update the recipe so EMI & REI can work with the recipe.

@Xelbayria Xelbayria closed this as not planned Won't fix, can't repro, duplicate, stale Dec 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.20.1-FORGE Minecraft Version bug Something isn't working recalcitrant won't fix or cannot solve
Projects
None yet
Development

No branches or pull requests

2 participants