fix(late bytes): add optional param of session_id so we can be explicit #90

jayceslesar · 2024-08-17T19:59:01Z

maybe close #86 🤷

jayceslesar · 2024-08-17T20:00:56Z

masterbase/lib.py

 steam_id: str,
 late_bytes: bytes,
 current_time: datetime,
+ session_id: str | None = None,
 ) -> str | None:
 """Add late bytes to the database and blob storage.

 No-ops and returns an error message if late bytes are found or there are no active sessions.
 """
 with engine.connect() as conn:


this function getting super ugly...

fix(late bytes): add optional param of session_id so we can be explicit

11967e8

jayceslesar commented Aug 17, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(late bytes): add optional param of session_id so we can be explicit #90

fix(late bytes): add optional param of session_id so we can be explicit #90

jayceslesar commented Aug 17, 2024

jayceslesar Aug 17, 2024

fix(late bytes): add optional param of session_id so we can be explicit #90

Are you sure you want to change the base?

fix(late bytes): add optional param of session_id so we can be explicit #90

Conversation

jayceslesar commented Aug 17, 2024

jayceslesar Aug 17, 2024

Choose a reason for hiding this comment