Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"end" times in properties causes problems with generic property handling code #28

Open
EthanSteinberg opened this issue May 11, 2024 · 2 comments
Labels
enhancement New feature or request

Comments

@EthanSteinberg
Copy link
Collaborator

EthanSteinberg commented May 11, 2024

The current design has end times (for visits, procedures, etc) in properties, which is somewhat simple and matches the source data.

However, this can cause issues with generic property handling code as it will leak future information (the end of the visit) into the past.

This also makes certain types of operations cumbersome.

The solution here is to introduce a new event type, DISCHARGE, for visits. That DISCHARGE event would be linked to the visit via visit_id.

I would propose using code=MEDS/Discharge for these events, with no ontology linkages.

@mmcdermott
Copy link

I would recommend this for all "interval" type events (e.g., procedures, infusions, etc.) with appropriate non-linked codes.

@EthanSteinberg EthanSteinberg changed the title "end" times for visits in properties causes problems with generic property handling code "end" times in properties causes problems with generic property handling code May 11, 2024
@EthanSteinberg
Copy link
Collaborator Author

@mmcdermott Good point. Fixed.

@EthanSteinberg EthanSteinberg added the enhancement New feature or request label May 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants