Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove domready call #21

Open
simonsmith opened this issue Mar 22, 2013 · 0 comments
Open

Remove domready call #21

simonsmith opened this issue Mar 22, 2013 · 0 comments

Comments

@simonsmith
Copy link

On my site I have a MooTools build without the domready module included (a common occurrence, eg scripts at bottom or using AMD) and the reference to it on this line causes the script to fail - https://github.com/ceramedia/CeraBox/blob/master/cerabox.js#L609

Consider removing this and leave the DOM readiness up to the user of the plugin. Alternatively, explicitly list which Core modules the plugin requires.

Apart from this minor issue, a really wonderful plugin. Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant