Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

On the model selection #3

Open
YBZh opened this issue Aug 2, 2021 · 0 comments
Open

On the model selection #3

YBZh opened this issue Aug 2, 2021 · 0 comments

Comments

@YBZh
Copy link

YBZh commented Aug 2, 2021

In your paper, you write: "we conduct the leave-one-domain-out evaluation. We train our model on the training splits and select the best model on the validation splits of all source domains"

But, in my opinion and according to the description in "https://github.com/facebookresearch/DomainBed", "select the best model on the validation splits of all source domains" is the "Training-domain validation" or "IIDAccuracySelectionMethod", rather than the " leave-one-domain-out evaluation".

What's your opiniton? Thanks for your reply.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant