Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAT-6167: Update dev snapshot to support madie-java-models updates #539

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

mcmcphillips
Copy link
Contributor

MADiE PR

Jira Ticket: MAT-6167
(Optional) Related Tickets:

Summary

Measure service needs to know about the changes in madie-java-models in order to save measure.measureMetaData.measureDefinitions.

All Submissions

  • This PR has the JIRA linked.
  • Required tests are included.
  • No extemporaneous files are included (i.e Complied files or testing results).
  • This PR is merging into the correct branch.
  • All Documentation needed for this PR is Complete (or noted in a TODO or other Ticket).
  • Any breaking changes or failing automations are noted by placing a comment on this PR.

DevSecOps

If there is a question if this PR has a security or infrastructure impact, please contact the Security or DevOps engineer assigned to this project to discuss it further.

  • This PR has NO significant security impact (i.e Changing auth methods, Adding a new user type, Adding a required but vulnerable package).

Reviewers

By Approving this PR you are attesting to the following:

  • Code is maintainable and reusable, reuses existing code and infrastructure where appropriate, and accomplishes the task’s purpose.
  • The tests appropriately test the new code, including edge cases.
  • If you have any concerns they are brought up either to the developer assigned, security engineer, or leads.

@mcmcphillips mcmcphillips requested a review from a team as a code owner January 4, 2024 18:01
Copy link

codecov bot commented Jan 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (7608ee7) 94.51% compared to head (bb5be38) 94.51%.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #539   +/-   ##
========================================
  Coverage    94.51%   94.51%           
========================================
  Files           98       98           
  Lines         3297     3297           
  Branches       432      432           
========================================
  Hits          3116     3116           
  Misses          79       79           
  Partials       102      102           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant