Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

issues with indenting #5

Closed
Feel-ix-343 opened this issue Mar 22, 2024 · 7 comments
Closed

issues with indenting #5

Feel-ix-343 opened this issue Mar 22, 2024 · 7 comments
Labels
bug Something isn't working

Comments

@Feel-ix-343
Copy link

markdownnvim

I think you may assume 2 space indent level
@MeanderingProgrammer
Copy link
Owner

While I don't assume a 2 space indent I did assume tree-sitter would always return list items with any leading spaces removed, hoping it would take care of whatever level of nesting. This does not appear to be the case though :(

Thanks for reporting this!

@MeanderingProgrammer MeanderingProgrammer added the bug Something isn't working label Mar 22, 2024
@MeanderingProgrammer
Copy link
Owner

Appears to be a known issue with the underlying parser: tree-sitter-grammars/tree-sitter-markdown#127

Closed
@Feel-ix-343
Copy link
Author

I sent you an email too btw ;)

MeanderingProgrammer added a commit that referenced this issue Mar 22, 2024
@MeanderingProgrammer
Handle leading spaces for list_items
df98da8 
## Details

As reported in the following issues:

* #2
* #5

The list_items we capture from tree-sitter will sometimes have
leading spaces leading to us rendering a bullet point incorrectly.

Add some logic on our side to handle these cases.
@MeanderingProgrammer
Copy link
Owner

I sent you an email too btw ;)

Sorry am bad at checking my email will get to it shortly!

@MeanderingProgrammer
Copy link
Owner

Issue should be resolved by: df98da8

@Feel-ix-343
Copy link
Author

Incredible!

@Feel-ix-343
Copy link
Author

works.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@MeanderingProgrammer @Feel-ix-343