Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Federate images in comments #978

Open
aaronliu0130 opened this issue Aug 2, 2024 · 2 comments
Open

Federate images in comments #978

aaronliu0130 opened this issue Aug 2, 2024 · 2 comments
Labels
activitypub ActivityPub related issues needs feedback Requires a greater consensus to make an informed decision

Comments

@aaronliu0130
Copy link

Is your feature request related to a problem? Please describe.
Currently, attaching images in comments to threads only federates to microblog stuff at most. They aren't visible to e.g. Lemmy users.

Describe the solution you'd like
Send the image embedded in the post as a fallback with ![alt text](URL)

Describe alternatives you've considered
Drag Lemmy backstage and take its head off
@aaronliu0130 aaronliu0130 added the enhancement New feature or request label Aug 2, 2024
@BentiGorlich BentiGorlich added needs feedback Requires a greater consensus to make an informed decision activitypub ActivityPub related issues and removed enhancement New feature or request labels Aug 3, 2024
@BentiGorlich
Copy link
Member

The problem with additionally adding the embedded ![alt text](URL) is that it actually correctly federates from mbin <-> mbin. So we could show the representation differently for lemmy servers, but I don't know if I would like it. If lemmy does not support images in comments it is an issue in their implementation. I would ask you to additionally to this issue open up one on the lemmy side and link it to this one here.

@aaronliu0130 aaronliu0130 mentioned this issue Aug 3, 2024
Closed
5 tasks
@aaronliu0130
Copy link
Author

The Lemmy issue is LemmyNet/lemmy#2456.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
activitypub ActivityPub related issues needs feedback Requires a greater consensus to make an informed decision
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@aaronliu0130 @BentiGorlich