Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Add Data Class" and "Add Rule" buttons shouldn't appear while logged out (cosmetic issue only- functionality is disabled/errors out) #835

Open
notama-nr2527 opened this issue Jan 11, 2024 · 2 comments
Labels
bug Something isn't working

Comments

@notama-nr2527
Copy link

notama-nr2527 commented Jan 11, 2024

Description

Two buttons shouldn't appear while logged out (cosmetic issue only- functionality is disabled/errors out)

  1. "Add Data Class"
  2. "Add Rule" x 2

Steps to reproduce

"Add Data Class"
0. Open $BROWSER in Incognito mode

  1. Go to root of website
  2. Click on a Data Asset
  3. Click on "Schema" separator
  4. See button "+ Add Data Class"

"Add Rule pt I"
0. Open $BROWSER in Incognito mode

  1. Go to root of website
  2. Click on a Data Asset
  3. Click on "Rules" separator
  4. See button "+ Add Rule"

"Add Rule pt II"
0. Open $BROWSER in Incognito mode

  1. Go to root of website
  2. Click on a Data Class
  3. Click on "Rules" separator
  4. See button "+ Add Rule"

Expected behavior

Buttons should not appear when logged out.

Screenshots

image

image

image

Environment

Desktop

Please complete the following information:

  • OS: Windows 10 22H2
  • Browser: Brave Browser: 1.61.116 Chromium: 120.0.6099.217 (Official Build) (64-bit)
  • Version: mdm-docker 7.2.0

Thanks!

@notama-nr2527 notama-nr2527 added the bug Something isn't working label Jan 11, 2024
@jamesrwelch
Copy link
Contributor

Thanks @ItCatMod - bug reports are very much appreciated! In some cases the back-end tells the UI what buttons can be shown to happen so it may be an error there - we'll take a look and sort it out!

@notama-nr2527
Copy link
Author

Preliminary work on: https://github.com/ItCatMod/mdm-ui/tree/hide_buttons_when_logged_out . I'm pretty sure I forgot one of the buttons.

PS: based on 'main' branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants