Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reliable enough for integration testing? #19

Open
lukepighetti opened this issue Sep 26, 2018 · 3 comments
Open

Reliable enough for integration testing? #19

lukepighetti opened this issue Sep 26, 2018 · 3 comments
Labels

Comments

@lukepighetti
Copy link

lukepighetti commented Sep 26, 2018

Hi Matthieu, really interested what you've built here and I really enjoyed your Medium article.

I was looking for a way to receive notifications on Node.js for the purpose of integration testing our FCM push notifications.

Do you feel this package is reliable enough for integration testing push notifications in a CI pipeline?

Cheers

@MatthieuLemoine
Copy link
Owner

MatthieuLemoine commented Sep 27, 2018

Hi Luke,

It's a good idea! Never thought of it.

Well, first FCM doesn't guarantee to deliver a push notification but it almost always does 😄

About push-receiver specifically, we do have tests although they aren't run every day.

You can sometimes have issues during registration but listening for notifications works pretty well.

Would love if you could try and give me a feedback about CI usage. I think others would like this idea of testing FCM notifications.

@lukepighetti
Copy link
Author

lukepighetti commented Sep 27, 2018

One more question I have before adding it: how long does it usually take between sending FCM notification and push-receiver getting the notification?

I looked at your tests and at first glance it looks like you're doing an end-to-end test of FCM send & receive.

@MatthieuLemoine
Copy link
Owner

I don't have numbers but it's a matter of seconds

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants